Opened 11 years ago

Closed 11 years ago

#6819 closed task (fixed)

Miscellaneous MythVideo Storage Group Fixes/Improvements

Reported by: robert.mcnamara@… Owned by: robertm
Priority: minor Milestone: unknown
Component: Plugin - MythVideo Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch adds support for the remotefile write capability, allowing MythVideo? to download metadata images straight into the Coverart/Fanart/Banner? storage groups. This takes us fairly close to the point where we can eliminate the local mounts for coverart/fanart/screenshot/etc. in MythVideo?.

Unfortunately the patch exposes a bug elsewhere in MythVideo? that I have not yet been able to track down. When fanart/banner/coverart are downloaded, all the correct files end up in the correct storage group. For some reason, however, MythVideo? can load the wrong image in as the wrong imagetype. ie, the file downloaded for coverart ends up displaying as the fanart. Note that the file download works properly. Clearing the frontend themecache and going back to the image loads all the correct images. This appears to be a bug with either image caching or somewhere else in MythVideo?. I'd love any assistance with tracking this one down.

Attachments (2)

MetaSGs.diff (17.3 KB) - added by robert.mcnamara@… 11 years ago.
Download images to their storage groups when possible.
MVDeletefix.diff (26.2 KB) - added by robert.mcnamara@… 11 years ago.
Replaces previous, adds "Remove File" support and scanning corrections

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by robert.mcnamara@…

Attachment: MetaSGs.diff added

Download images to their storage groups when possible.

Changed 11 years ago by robert.mcnamara@…

Attachment: MVDeletefix.diff added

Replaces previous, adds "Remove File" support and scanning corrections

comment:1 Changed 11 years ago by robert.mcnamara@…

New patch adds a few other Storage Group in MythVideo? related fixes. Can now download all the following to Storage Groups: Fanart, Coverart, Banner, and (newly implemented) Screenshots. This also adds support for deleting Videos from the UI. It also fixes bug #6068 (segfault on delete) by invalidating the tree before refreshing the view (calling reloaddata instead of refreshdata). It also fixes scanning when there is also a local setting for Mythvideo files, so that it will prefer the Storage Group and bypass the local mount (preventing duplicate scans and still allowing the media to be locally mounted).

comment:2 Changed 11 years ago by robertm

(In [21206]) Refs #6819, Change video scan behavior to prefer Storage Groups when they exist, and to not scan local mounts when they do. Fixes obnoxious behavior where a local mount and SG exist and you end up with two records after a scan. Also prevents the (useless) 'Video Home' node from showing up.

comment:3 Changed 11 years ago by robertm

Owner: changed from Anduin Withers to robertm
Status: newassigned
Summary: Allow MythVideo to download metadata to Image StoragegroupsMiscellaneous MythVideo Storage Group Fixes/Improvements
Type: patchtask

comment:4 Changed 11 years ago by robertm

(In [21246]) Fixes #6068. Refs #6819. Fix deletes in MythVideo?. Deletes will now work for both storage group and local mount configurations, with one caveat on each. We must still reload the tree on local deletes, otherwise when the last item in a folder is removed and you back out of it, a segfault occurs. For Storage Group deletes, one needs to leave mythvideo and allow the cache to die (as with scanning) for the change to 'take.'

comment:5 Changed 11 years ago by robertm

Resolution: fixed
Status: assignedclosed

Meant to close this w/ r21391. All of the attached improvements save one have been committed.

Note: See TracTickets for help on using tickets.