Opened 11 years ago

Closed 11 years ago

#6820 closed defect (fixed)

Invalid default values specified for some fields in MythArchive dbcheck.cpp

Reported by: Jonathan Martens <jonathan@…> Owned by: Rob Smith
Priority: trivial Milestone: unknown
Component: Plugin - MythArchive Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Like issue #6802 there are also invalid default values specified in the create statement of the mytharchive dbcheck.cpp file. This prevents the upgrade of the tables from running to the latest version as MySQL errors out on the query.

According to http://dev.mysql.com/doc/refman/5.1/en/blob.html:

"In most respects, you can regard a BLOB column as a VARBINARY column that can be as large as you like. Similarly, you can regard a TEXT column as a VARCHAR column. BLOB and TEXT differ from VARBINARY and VARCHAR in the following ways:

  • For indexes on BLOB and TEXT columns, you must specify an index prefix length. For CHAR and VARCHAR, a prefix length is optional. See Section 7.4.2, “Column Indexes”.
  • BLOB and TEXT columns cannot have DEFAULT values."

Please find attached a patch to fix this.

Attachments (1)

mythplugins-mytharchive-mytharchive-dbcheck_cpp.patch (877 bytes) - added by Jonathan Martens <jonathan@…> 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by Jonathan Martens <jonathan@…>

comment:1 Changed 11 years ago by danielk

Milestone: 0.22unknown
Priority: blockertrivial
Severity: mediumlow

comment:2 Changed 11 years ago by Rob Smith

Owner: changed from paulh to Rob Smith
Status: newaccepted

comment:3 Changed 11 years ago by Rob Smith

Resolution: fixed
Status: acceptedclosed

(In [22384]) Fixes #6802, Fixes #6820, this allows the database schema updates to run on mysql database running in strict modes

Note: See TracTickets for help on using tickets.