Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#6824 closed task (fixed)

Speed up mythcommflag

Reported by: danielk Owned by: beirdo
Priority: minor Milestone: 0.24
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

See if avformatdecoder settings can speed up mythcommflag without losing too much in the way of accuracy.

Attachments (5)

6824-v1.patch (15.0 KB) - added by danielk 10 years ago.
Proof of concept patch
6824-v2.patch (17.3 KB) - added by beirdo 9 years ago.
6824-v3.patch (17.6 KB) - added by beirdo 9 years ago.
6824-v4.patch (16.3 KB) - added by beirdo 9 years ago.
6824-v5.patch (17.5 KB) - added by beirdo 9 years ago.

Download all attachments as: .zip

Change History (17)

Changed 10 years ago by danielk

Attachment: 6824-v1.patch added

Proof of concept patch

comment:1 Changed 10 years ago by Dibblah

Status: newassigned

Changed 9 years ago by beirdo

Attachment: 6824-v2.patch added

comment:2 Changed 9 years ago by beirdo

Version: head0.23rc2

I'm not guaranteeing that this patch is correct, but I've done my best to update it to be off trunk ([25462] in fact). Daniel, or someone else, could you verify that I shoehorned in the rejects correctly? In particular, the one with the sws_scale is done differently now, and I'm not sure I got it quite right.

comment:3 Changed 9 years ago by beirdo

Version: 0.23rc2Unspecified

comment:4 Changed 9 years ago by beirdo

Version: UnspecifiedTrunk Head

comment:5 Changed 9 years ago by beirdo

sorry, had a browser scroll failure there.

comment:6 Changed 9 years ago by anonymous

OK, there's at least one tweak to be made to the patch... in avformatdecoder.cpp, a gContext needs to be changed to gCoreContext to get it to compile.

Changed 9 years ago by beirdo

Attachment: 6824-v3.patch added

comment:7 Changed 9 years ago by beirdo

The last patch has the stated tweak so it will compile. Please note these patches are made with git format-patch, and you may need to remove the mail headers from them first if your patch program can't handle it.

comment:8 Changed 9 years ago by beirdo

Owner: changed from danielk to beirdo

Changed 9 years ago by beirdo

Attachment: 6824-v4.patch added

comment:9 Changed 9 years ago by beirdo

Updated the patch to allow for the CommFlagFast? setting to be 0 in the database, and enabled the one last enhancement.

comment:10 Changed 9 years ago by beirdo

Newest version includes setting the CommFlagFast? db setting from the General (Jobs) setup page in the frontend (where the commflag type is set). It now defaults to disabling if there's no setting found in the db, and is treated as a boolean.

This setting will be removed once this patch has been sufficiently tested, at which point, a commandline option will be added to force a disable.

Changed 9 years ago by beirdo

Attachment: 6824-v5.patch added

comment:11 Changed 9 years ago by beirdo

Resolution: fixed
Status: assignedclosed

(In [25657]) Added commercial detection speedups. This works primarily by using a scaled down version of the recording to detect commercials (1/4 width, 1/4 height), and by doing blank frame detection using less of the frame.

Preliminary testing has shown that the commercial breaks found are as accurate if not more accurate with this enabled as with it disabled, with occasional missed commercials. This seems no worse than without it, and commercial detection is not a simple thing anyways.

There is a new setting in the TV -> General (Jobs) screen to allow the user to enable these speedups, and the default is to have the speedups disabled.

Closes #6824

comment:12 Changed 9 years ago by beirdo

Milestone: unknown0.24
Note: See TracTickets for help on using tickets.