Opened 10 years ago

Closed 10 years ago

#6827 closed patch (fixed)

Fix DeleteFile namespace conflict on win32

Reported by: Jeff Lu <jll544@…> Owned by: Nigel
Priority: minor Milestone: 0.22
Component: Ports - Windows Version: head
Severity: medium Keywords: win32 deletefile
Cc: Ticket locked: no

Description

Win32 builds broke at r21156 due to a namespace conflict with Windows' DeleteFile? macro. The attached patch undefines the problem macro.

Ref: http://www.gossamer-threads.com/lists/mythtv/dev/391454

Attachments (2)

6827-deletefile.patch (406 bytes) - added by Jeff Lu <jll544@…> 10 years ago.
6827-deletefile.2.patch (337 bytes) - added by Jeff Lu <jll544@…> 10 years ago.
Single-line version of the patch

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Jeff Lu <jll544@…>

Attachment: 6827-deletefile.patch added

comment:1 Changed 10 years ago by cpinkham

Can you see if you can just #undef this near the top of compat.h with all the other Win32 undefs?

Changed 10 years ago by Jeff Lu <jll544@…>

Attachment: 6827-deletefile.2.patch added

Single-line version of the patch

comment:2 in reply to:  1 Changed 10 years ago by Jeff Lu <jll544@…>

Replying to cpinkham:

Can you see if you can just #undef this near the top of compat.h with all the other Win32 undefs?

Heh, I didn't notice the other ones up there. Yes, the build works fine if you move #undef DeleteFile? up there - just tested it now.

comment:3 Changed 10 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [21209]) Fix DeleteFile? namespace conflict on win32.

Closes #6827.

Note: See TracTickets for help on using tickets.