Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#6849 closed defect (fixed)

Hue setting changes between xv-blit and vdpau

Reported by: anonymous Owned by: markk
Priority: minor Milestone: 0.22
Component: MythTV - Video Playback Version: head
Severity: low Keywords:
Cc: Ticket locked: yes

Description

I'm running latest trunk and had a go at creating a new Playback profile with:

  1. if rez >= 1024 -> vdpau & vdpau

Advanced 2x , Advanced 1x

  1. if rez < 1024 -> ffmpeg & Xvideo

Linear Blend , Yadif

This all works great except that when watching SD with XV HUE needs to be set to 50% and when i watch HD HUE must be changed to 0% for the colors to be right.

Nvidia Driver is 185.18.31

Is this an Nvidia problem or Mythtv problem?

Change History (3)

comment:1 Changed 9 years ago by markk

Milestone: unknown0.22
Owner: changed from Isaac Richards to markk
Severity: mediumlow
Status: newaccepted

comment:2 Changed 9 years ago by markk

Resolution: fixed
Status: acceptedclosed

(In [21522]) Fix the XVideo hue range for NVIDIA drivers.

The default range of the hue setting has been changed in more recent drivers, which broke the existing 'hue base' assumption. Instead of trying to guess the appropriate adjustment from the driver version etc, we use the XV_SET_DEFAULTS attribute to restore the xvideo attributes to their defaults and calculate the appropriate range offset from that. The behaviour is unchanged if the XV_SET_DEFAULTS attribute is not available.

We do however need to save the existing attribute values and later restore them. This has the added bonus/side-effect of restoring the xvideo port attributes to the state in which MythTV found them (possibly with the exception of XV_COLORKEY and XV_AUTOPAINT_COLORKEY).

Technically we should probably revisit the offset assumptions for all xvideo attributes in 0.23 and rebase the hue setting generally - as most implementations now seem to use a default of 50% of the range rather than the 0% we assume.

Closes #6849. Closes #6778.

comment:3 Changed 8 years ago by stuartm

Ticket locked: set
Note: See TracTickets for help on using tickets.