Opened 10 years ago

Closed 10 years ago

#6856 closed patch (fixed)

Memory leaks in MythWeather

Reported by: Marc Alban <marcalban@…> Owned by: Isaac Richards
Priority: minor Milestone: 0.22
Component: Plugin - MythWeather Version: head
Severity: low Keywords: MythWeather Memory Leaks
Cc: Ticket locked: no

Description

There are quite a few potential memory leaks in MythWeather?, several of which occur during normal operation.

There are at least 10 minor leaks caused by not freeing resources in failure cases. Usually when a theme is missing elements.

There is a significant leak of all search results when adding a new screen.

There are leaks of ScreenListInfo? and WeatherSource? objects in various cases.

This patch overlaps my patch for #6782. If that patch gets committed first I will update this one. Otherwise, if this patch gets committed first it will also resolve that issue.

Attachments (1)

weather_leaks.patch (18.6 KB) - added by Marc Alban <marcalban@…> 10 years ago.
Patch to fix memory leaks in MythWeather?

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: weather_leaks.patch added

Patch to fix memory leaks in MythWeather?

comment:1 Changed 10 years ago by Marc Alban <marcalban@…>

The patch also removes a constructor for WeatherSource? which is never referenced, but which would result in a leak if called.

comment:2 Changed 10 years ago by paulh

Resolution: fixed
Status: newclosed

(In [21443]) Fix a problem in MythWeather? were it would only allow one location/source per screen type to be set. Fixes #6782.

Also fixes several memory leaks. Fixes #6856.

Patch by Marc Alban.

Note: See TracTickets for help on using tickets.