Opened 10 years ago

Closed 10 years ago

#6873 closed patch (fixed)

Assert failure caused by MythUIButtonTree

Reported by: Marc Alban <marcalban@…> Owned by: stuartm
Priority: minor Milestone: 0.22
Component: MythTV - User Interface Library Version: head
Severity: medium Keywords: MythUI Crash
Cc: Ticket locked: no

Description

The frontend crashes for me when traversing a button tree to a leaf node on the right. I experienced the crash in the MythGame? plugin.

It appears to be an index off-by-one error introduced in [18256].

I think the patch is self explanatory in terms of fixing the off-by-one error. I think it also maintains the expected logic of the button tree, but I'm not that familiar with the code or the button tree.

Attachments (2)

buttontree.backtrace​ (4.2 KB) - added by Marc Alban <marcalban@…> 10 years ago.
Backtrace of the button tree failure.
buttontree.patch​ (516 bytes) - added by Marc Alban <marcalban@…> 10 years ago.
patch to fix the of-by-one error in the button tree.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: buttontree.backtrace​ added

Backtrace of the button tree failure.

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: buttontree.patch​ added

patch to fix the of-by-one error in the button tree.

comment:1 Changed 10 years ago by stuartm

Status: new → accepted

comment:2 Changed 10 years ago by Marc Alban <marcalban@…>

I also just realized that this error is only repeatable for me in MythGame? when I'm using the MythCenter? non-wide screen where there are only two columns of the tree visible. With the wide theme there are three columns and the error doesn't occur.

comment:3 Changed 10 years ago by paulh

Resolution: → fixed
Status: accepted → closed

(In [21723]) Fix an off by one error in MythUIButtonTree. Patch by Marc Alban. Fixes #6873.

Note: See TracTickets for help on using tickets.