Opened 11 years ago

Closed 10 years ago

#6900 closed defect (fixed)

win32-packager fixes - SDL ( and QT )

Reported by: davidbuzz@… Owned by: markk
Priority: minor Milestone: 0.22
Component: Ports - Windows Version: head
Severity: medium Keywords: win32
Cc: Ticket locked: no


SDL default Makefile from tar file is broken under mingw. A redo of ./configure fixes it.

SDL no longer has a target of 'make install-sdl' it's just 'make install'

...also... QT software takes forever to download, and doesn't warn. it appears hung.

Attachments (2)

SDL-6900.patch (1.0 KB) - added by davidbuzz@… 11 years ago.
win32 SDL fixes.
6900-w32pkg.patch (2.4 KB) - added by Jeff Lu <jll544@…> 10 years ago.
Revised patch: change SDL extract condition, add QT warning, and stream downloads to disk

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by davidbuzz@…

Attachment: SDL-6900.patch added

win32 SDL fixes.

comment:1 Changed 10 years ago by markk

Owner: changed from Nigel to markk
Status: newaccepted

comment:2 Changed 10 years ago by Jeff Lu <jll544@…>

Buzz, Did 'make install-sdl' fail while using the script, or were you doing this manually? I ran the existing script today, and 'make install-sdl' worked fine. Perhaps you were using the source tarball instead of the binaries? The script is downloading the binaries (SDL-devel-1.2.13-mingw32.tar.gz), which doesn't include the top-level configure that your patch calls for.

comment:3 Changed 10 years ago by davidbuzz@…

the script fails for me when trying to install SDL ( assume binaries ), so I manually attempted install of them ( I assume I accidentially used the source version? ).

So, I guess this invalidates the SDL part of my patch, but doesn't fix the problem, which was that the script aborted when the SDL-related code failed to behave as expected. Buzz.

comment:4 Changed 10 years ago by Jeff Lu <jll544@…>

The script works on a clean machine, so probably you have a source copy of SDL leftover from an older version of the script. Both binaries and source tarballs extract into sources/SDL-1.2.13, and the script is only checking the existence of the directory. To cover this upgrade scenario, the script could be pointed instead to some unique file in the binary tarball.

Changed 10 years ago by Jeff Lu <jll544@…>

Attachment: 6900-w32pkg.patch added

Revised patch: change SDL extract condition, add QT warning, and stream downloads to disk

comment:5 Changed 10 years ago by Jeff Lu <jll544@…>

Revised patch attached. Changes: make SDL extract conditional on SDL.dll, and stream downloads to disk (see below). Also catch SIGINT to allow cleanup if script is aborted during a download.

It turns out the QT download was taking /forever/ due to Perl being inefficient at handling the large file in memory. I've replaced the fetch code with a version that streams the file to disk rather than holding it in memory. With this version, the download should run at full speed, and Perl won't consume CPU/memory as it was.

comment:6 Changed 10 years ago by markk

Resolution: fixed
Status: acceptedclosed

Fixed in r21659.

Note: See TracTickets for help on using tickets.