Opened 18 years ago
Closed 18 years ago
#698 closed defect (fixed)
(In [7682]) Fixes #539. => Not really, the logic is wrong
Reported by: | Owned by: | danielk | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | chromakey osd |
Cc: | Ticket locked: | no |
Description
I think this got lost in the -dev list so I am submitting it as a ticket. "This commit" refers to 7682.
This commit is doing something wrong. Before this commit, I set the depth to 24 which gave X a pixel format of 32 bit ARGB and the chromakey osd worked like a charm. after this commit I get the following error:
VideoOutputXv?: Number of bits per pixel is 24, but we only support ARGB 32 bbp for ChromaKeyOSD.
But really, we have a depth of 24 with an additional 8 bits for the alpha channel for a total of 32 bit ARGB. In fact, I don't even think it is possible to set a depth of 32 for Nvidia cards so this is clearly checking the wrong thing. Reverting back to the previous code allows Chromakey osd to function again.
(In [8022]) Closes #698.
We really should be looking at the Visual rather than the depth for several things in videoout_xv, including this. But since this is just a sanity check for a not-yet-fully-implemented feature, I've relaxed the requirement a bit.
Please put future chromakey bugs reports on the "Chromakey OSD" task ticket #512 until that ticket is closed.