Opened 11 years ago

Closed 10 years ago

#6992 closed defect (fixed)

frontend caches wrong channel icon when filename is similar

Reported by: Mike Rice <mikerice1969@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: MythTV - General Version: head
Severity: low Keywords:
Cc: Ticket locked: no


Frontend requests icon:

2009-09-06 08:05:19.994 MythSocket(b2f2c40:35): write -> 35 83      ANN FileTransfer mythfrontend2 0 0 0[]:[]//root/.mythtv/channels/discovery.jpg[]:[]

Backend sends wrong icon:

2009-09-06 07:37:40.447 MythSocket(ffffffff9bd6f080:61): read  <- 61 83      ANN FileTransfer mythfrontend2 0 0 0[]:[]//root/.mythtv/channels/discovery.jpg[]:[]

2009-09-06 07:37:40.473 RingBuf(/root/.mythtv/channels/military_channel_discovery.jpg): OpenFile(/root/.mythtv/channels/military_channel_discovery.jpg, 0)

Due to the following code in mainserver.cpp where the query could return more than one filename:

       QString file = lpath.section('/', -1);
        lpath = "";

        MSqlQuery query(MSqlQuery::InitCon());
        query.prepare("SELECT icon FROM channel WHERE icon LIKE :FILENAME ;");
        query.bindValue(":FILENAME", QString("%") + file);

        if (query.exec() && query.isActive() && query.size())
            lpath = query.value(0).toString();

Changing the query as so works for me:

query.bindValue(":FILENAME", QString("%/") + file);

patch attached.

Attachments (1)

wrong_icon.patch (509 bytes) - added by Mike Rice <mikerice1969@…> 11 years ago.

Download all attachments as: .zip

Change History (2)

Changed 11 years ago by Mike Rice <mikerice1969@…>

Attachment: wrong_icon.patch added

comment:1 Changed 10 years ago by sphery

Resolution: fixed
Status: newclosed

(In [24637]) Fix channel icon selection when different channels have similar-ending file names.

Fixes #6992 with patch from Mike Rice.

Note: See TracTickets for help on using tickets.