Opened 10 years ago

Closed 10 years ago

#6999 closed defect (fixed)

Check query.next() in libmythupnp

Reported by: Erik Hovland <erik@…> Owned by: sphery
Priority: trivial Milestone: 0.22
Component: MythTV - General Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Check query.next() before working on the query object.

Attachments (1)

libs_libmythupnp-check-return (1.2 KB) - added by Erik Hovland <erik@…> 10 years ago.
Check query.next()

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Erik Hovland <erik@…>

Check query.next()

comment:1 Changed 10 years ago by sphery

Owner: changed from Isaac Richards to sphery
Status: newassigned

comment:2 Changed 10 years ago by paulh

Milestone: unknown0.22
Owner: changed from sphery to paulh

comment:3 Changed 10 years ago by paulh

Owner: changed from paulh to sphery

whoops mdean took it :)

comment:4 Changed 10 years ago by sphery

Resolution: fixed
Status: assignedclosed

(In [21719]) Ensure the return value of query.next() is checked and remove unnecessary query.size() checks. Fixes #6999.

While I was in there, I fixed all other locations in the file where size() was checked needlessly (and ensured there were no isActive() checks). Most of the changes are re-indentation.

Note: See TracTickets for help on using tickets.