Opened 11 years ago

Closed 11 years ago

#7013 closed defect (wontfix)

unused or unreachable code in Myth UI

Reported by: Erik Hovland <erik@…> Owned by: danielk
Priority: trivial Milestone: unknown
Component: MythTV - User Interface Library Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

  1. The value assigned to 'token3' is never used after the null check. Don't bother w/ the assignment.
  2. Same goes for 'end'.
  3. The return QString(""); will never be reached because every possibility is accounted for.

Attachments (1)

libs_libmythui-unused-value (1.9 KB) - added by Erik Hovland <erik@…> 11 years ago.
Fixes or removes unused or unreachable code.

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by Erik Hovland <erik@…>

Attachment: libs_libmythui-unused-value added

Fixes or removes unused or unreachable code.

comment:1 Changed 11 years ago by stuartm

(In [23244]) Refactor code to remove an unreachable call to return in MythVirtualKeyboard?. Patch from Erik Hovland. Refs #7013

comment:2 Changed 11 years ago by stuartm

Owner: changed from stuartm to danielk
Status: newassigned

comment:3 Changed 11 years ago by Erik Hovland <erik@…>

Please close this ticket. The LIRC code changes will be addressed upstream.

comment:4 Changed 11 years ago by Raymond Wagner

Resolution: wontfix
Status: assignedclosed

Closed per submitter's request.

Note: See TracTickets for help on using tickets.