Opened 15 years ago
Closed 14 years ago
#7015 closed defect (wontfix)
Remove or rework dead code in Myth UI
Reported by: | Owned by: | danielk | |
---|---|---|---|
Priority: | trivial | Milestone: | 0.23 |
Component: | MythTV - User Interface Library | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
- Once the use-after-free patch is applied, the check at line 913 in lirc_client.c is no longer necessary.
- The check of sockfd is not necessary. sockfd was closed before the goto was called.
- vdest.x0 and y0 are unsigned. So checking for < 0 will never be true. Fortunately r.x() returns a signed value. So check at assignment instead.
Attachments (1)
Change History (4)
Changed 15 years ago by
Attachment: | libs_libmythui-dead-code added |
---|
comment:1 Changed 15 years ago by
Milestone: | unknown → 0.23 |
---|---|
Status: | new → accepted |
comment:2 Changed 14 years ago by
Owner: | changed from stuartm to danielk |
---|---|
Status: | accepted → assigned |
Daniel last touched the lirc code, I'll let him decide whether to apply that part. The vdpau painter patch no longer applies in trunk, the code has been refactored.
comment:3 Changed 14 years ago by
Resolution: | → wontfix |
---|---|
Status: | assigned → closed |
This is really external code, unless it's a functional bug I don't want to mess with it other than syncing from upstream.
Note: See
TracTickets for help on using
tickets.
Remove or rework code that cannot execute.