Opened 10 years ago

Closed 10 years ago

#7015 closed defect (wontfix)

Remove or rework dead code in Myth UI

Reported by: Erik Hovland <erik@…> Owned by: danielk
Priority: trivial Milestone: 0.23
Component: MythTV - User Interface Library Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

  1. Once the use-after-free patch is applied, the check at line 913 in lirc_client.c is no longer necessary.
  2. The check of sockfd is not necessary. sockfd was closed before the goto was called.
  3. vdest.x0 and y0 are unsigned. So checking for < 0 will never be true. Fortunately r.x() returns a signed value. So check at assignment instead.

Attachments (1)

libs_libmythui-dead-code (1.6 KB) - added by Erik Hovland <erik@…> 10 years ago.
Remove or rework code that cannot execute.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Erik Hovland <erik@…>

Attachment: libs_libmythui-dead-code added

Remove or rework code that cannot execute.

comment:1 Changed 10 years ago by stuartm

Milestone: unknown0.23
Status: newaccepted

comment:2 Changed 10 years ago by stuartm

Owner: changed from stuartm to danielk
Status: acceptedassigned

Daniel last touched the lirc code, I'll let him decide whether to apply that part. The vdpau painter patch no longer applies in trunk, the code has been refactored.

comment:3 Changed 10 years ago by danielk

Resolution: wontfix
Status: assignedclosed

This is really external code, unless it's a functional bug I don't want to mess with it other than syncing from upstream.

Note: See TracTickets for help on using tickets.