Opened 15 years ago

Closed 15 years ago

#7018 closed defect (fixed)

mythfilldatabase error when downloading icons

Reported by: Jonas Bergström <jonasbergstrom666@…> Owned by: stuartm
Priority: minor Milestone: 0.22
Component: MythTV - Mythfilldatabase Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Running mythfilldatabase with tv_grab_se_swedb generates error when trying to download icons.

Looks like XMLTVParser::parseChannel appends a "/" to the iconpath that is recived from tv_grab_se_swedb wich results in a incorrect url.

example: 

should be HTTP://blaha.com/blaha.png
but we get /HTTP://blaha.com/blaha.png

I have made a patch to xmltvparser.cpp that checks if the first 4 chars in path is HTTP, if so then it just sets iconpath = path

Attachments (2)

xmltvparser.patch​ (599 bytes) - added by Jonas Bergström <jonasbergstrom666@…> 15 years ago.
patch for xmltvparser.cpp
mythfilldatabase.log​ (21.7 KB) - added by Jonas Bergström <jonasbergstrom666@…> 15 years ago.
log when error accure in mythfilldatabase

Download all attachments as: .zip

Change History (5)

Changed 15 years ago by Jonas Bergström <jonasbergstrom666@…>

Attachment: xmltvparser.patch​ added

patch for xmltvparser.cpp

Changed 15 years ago by Jonas Bergström <jonasbergstrom666@…>

Attachment: mythfilldatabase.log​ added

log when error accure in mythfilldatabase

comment:1 Changed 15 years ago by Jonas Bergström <jonasbergstrom666@…>

Running Trunk 21309

comment:2 Changed 15 years ago by stuartm

Milestone: unknown → 0.22
Status: new → accepted

comment:3 Changed 15 years ago by danielk

Resolution: → fixed
Status: accepted → closed

(In [22403]) Fixes #7018. Don't prepend baseUrl+/ when the icon path is already a URL in xmltvparser.cpp, instead validate the path as with QUrl and, if valid, use it directly.

Note: See TracTickets for help on using tickets.