Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#7049 closed defect (fixed)

Bookmark added at end of recording after automatically marked as watched

Reported by: lynchmv@… Owned by: sphery
Priority: minor Milestone: 0.22
Component: MythTV - Video Playback Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I've looked through the tickets, but can't seem to find one relating to this. With svn 21753, after a recording is watched and marked as watched automatically, it *appears* that there is a bookmark placed at the end of the recording, so when I go to play that recording again, it starts right at the end and exits to the prompt to keep or delete the recording. I need to verify that the bookmark is cleared on playback setting is set, but should the bookmark be set at all when a recording is done playing? I am assuming its a bookmark, but not absolutely sure b/c the bookmark icon isn't displayed when viewing the recording in the playback list.

root@mythmaster:~# mythbackend --version Please include all output in bug reports.

MythTV Version : 21753

MythTV Branch : trunk

Network Protocol : 48

Library API : 0.22.20090908-1

QT Version : 4.5.1

Options compiled in:

linux release using_oss using_alsa using_backend using_dvb using_frontend using_hdhomerun using_hdpvr using_iptv using_ivtv using_joystick_menu using_lirc using_mheg using_opengl_video using_opengl_vsync using_qtwebkit using_v4l using_x11 using_xrandr using_xv using_xvmc using_xvmc_vld using_xvmcw using_bindings_perl using_bindings_python using_opengl using_ffmpeg_threads using_live using_mheg

Change History (5)

comment:1 Changed 10 years ago by lynchmv@…

Just an update on this. The 'Clear Bookmark on Playback' option is checked, but the bookmark is not cleared when playing a recording, and indeed, a bookmark is set when a recording is done playing and you select 'Save this so I can watch it again'.

I tried unchecking 'Clear Bookmark on Playback' exiting mythfrontend, starting mythfrontend and enabling 'Clear Bookmark on Playback' then seeing if the bookmark would clear, but it did not.

Let me know if I need to try anything else or any other info is needed.

comment:2 Changed 10 years ago by sphery

Owner: changed from Janne Grunau to sphery
Status: newaccepted

comment:3 Changed 10 years ago by sphery

(In [21937]) Fix a bug that allowed the user to dismiss the end-of-recording prompt and attempt to resume playback because event handling didn't realize playback was at the end of the recording. Also removes now unused TV::IsNearEnd?() and isnearend field. Refs #7049.

comment:4 Changed 10 years ago by sphery

Resolution: fixed
Status: acceptedclosed

(In [22259]) Fixes #7049. Checks to see if exiting playback at the end of the recording before setting the bookmark. For users with "Prompt at end of recording," this change just prevents a bookmark from being set at the point where the prompt is displayed (and, since the end-of-recording prompt does not allow setting bookmarks, the change just makes Myth do the right thing). For users with the end-of-recording prompt disabled, this effectively prevents the user from setting a bookmark within the last 2s of the recording through the "Action on playback exit" (either "Save position and exit" or one of the "Prompt" values).

The fast-fingered (or really unlucky) user with end-of-recording prompts disabled can still set a bookmark within 2s of the end of recording, or any user can set a bookmark very close to the point where playback will exit by using the SELECT key. Doing so may make it hard for the user to react in time when resuming playback at the bookmark, but those users can simply restart playback from the beginning (INFO|Play from...|Play from beginning) and clear the bookmark or set it at a more appropriate place.

I may change the approach being used to fix this issue after 0.22 is released wi th some patches I have, but those patches change more than I want to change during a feature freeze. Alternatively, the root issue (user is unable to react before playback exits if the bookmark is too close to the end of recording) may be fixed as a result of changes to end-of-recording handling related to #6974.

comment:5 Changed 10 years ago by sphery

Milestone: unknown0.22
Note: See TracTickets for help on using tickets.