Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#7056 closed defect (fixed)

Mythvideo crashes after deleting a video and exiting

Reported by: dm66@… Owned by: robertm
Priority: major Milestone: 0.22
Component: Plugin - MythVideo Version: head
Severity: high Keywords:
Cc: Ticket locked: no

Description

Mythvideo crashes after you delete a video and try to return to the main menu (press escape)

Attachments (1)

crash.txt (2.9 KB) - added by anonymous 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by anonymous

Attachment: crash.txt added

comment:1 Changed 10 years ago by anonymous

Just since svn changes so rapidly, this is the exact line videodlg.cpp:3017

3017                               if (!metadata->GetHost().isEmpty() &&
3018                                   !metadata->GetCoverFile().startsWith("/"))
3019                                {

comment:2 Changed 10 years ago by robertm

Owner: changed from Anduin Withers to robertm
Status: newassigned

Code above isn't actually directly responsible for the crash. This segfault only occurs after having deleted the last node in a folder. For whatever reason, the MythGenericTree? still reports the subnodes as both valid and visible when backing out, even though their metadata has been deleted and they've ostensibly been marked invisible. Will look for a solution in the widget itself, otherwise maybe a MythVideo? workaround can be found.

comment:3 Changed 10 years ago by anonymous

I can reproduce this even if it's NOT the last node (video) in the folder. It's 100% reproduceable.

comment:4 Changed 10 years ago by r.d.vaughan@…

I am also finding this issue and the deleted item was not to my knowledge the last node, trunk r21855.

comment:5 Changed 10 years ago by robertm

Resolution: fixed
Status: assignedclosed

(In [21886]) Fixes #7056. Make sure to delete the item from both the MythGenericTree? as well as the buttontree/buttonlist. If a folder becomes empty, reload the tree to prevent orphaned folders (and associated segfaults).

comment:6 Changed 10 years ago by robertm

(In [21887]) Refs #7056. Reverts a part of prior commit triggers a segfault in 1/3 instances. This leaves a potential segfault if you delete the last item in a folder and then scan without leaving mythvideo, but it's a step in the right direction. I'm sure there's some mythgenerictree cleanup I should be doing that I'm not...

Note: See TracTickets for help on using tickets.