Mythvideo crashes after deleting a video and exiting

[dm66@…]

Mythvideo crashes after you delete a video and try to return to the main menu (press escape)

[anonymous]

Just since svn changes so rapidly, this is the exact line videodlg.cpp:3017

3017                               if (!metadata->GetHost().isEmpty() &&
3018                                   !metadata->GetCoverFile().startsWith("/"))
3019                                {

[robertm]

Code above isn't actually directly responsible for the crash. This segfault only occurs after having deleted the last node in a folder. For whatever reason, the MythGenericTree? still reports the subnodes as both valid and visible when backing out, even though their metadata has been deleted and they've ostensibly been marked invisible. Will look for a solution in the widget itself, otherwise maybe a MythVideo? workaround can be found.

[anonymous]

I can reproduce this even if it's NOT the last node (video) in the folder. It's 100% reproduceable.

[r.d.vaughan@…]

I am also finding this issue and the deleted item was not to my knowledge the last node, trunk r21855.

[robertm]

(In [21886]) Fixes #7056. Make sure to delete the item from both the MythGenericTree? as well as the buttontree/buttonlist. If a folder becomes empty, reload the tree to prevent orphaned folders (and associated segfaults).

[robertm]

(In [21887]) Refs #7056. Reverts a part of prior commit triggers a segfault in 1/3 instances. This leaves a potential segfault if you delete the last item in a folder and then scan without leaving mythvideo, but it's a step in the right direction. I'm sure there's some mythgenerictree cleanup I should be doing that I'm not...