Opened 11 years ago

Closed 11 years ago

#7087 closed defect (invalid)

CDRip should have an Alphabetic subdirectory option

Reported by: jord.swart@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: Plugin - MythMusic Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The current CDRIP only features GENRE, ALBUM, ARTIST, TRACK and TITLE for creating subdirectories. It would be nice to have a possibility to also create and alphabetic structure:

P/Portishead/Dummy/01.... P/Pearl Jam/Ten?/01 ...

I'm not a programmer, but the following diff for cdrip.cpp should be able to do such a thing. I am aware that I did not check all the dependencies (i18n files etc.) or the user help files. I am also aware that it is a very primitive patch. Ideally bands like "the police" should end up in the "P" category IMHO but that might just be a question of taste.

939c939 < QRegExp rx("(GENRE|ARTIST|ALBUM|TRACK|TITLE|YEAR)"); ---

QRegExp rx("(ALPHABETIC|GENRE|ARTIST|ALBUM|TRACK|TITLE|YEAR)");

955c955,958 < if ((rx.capturedTexts()[1] == "ARTIST") && (track->FormatArtist?() != "")) ---

if ((rx.capturedTexts()[1] == "ALPHABETIC") && (track->FormatArtist?() != ""))

filename += fixFileToken(track->FormatArtist?()).substr(0,0);

if ((rx.capturedTexts()[1] == "ARTIST") && (track->FormatArtist?() != ""))

Change History (3)

comment:1 Changed 11 years ago by paulh

Component: MythTV - GeneralPlugin - MythMusic

comment:2 Changed 11 years ago by robertm

Status: newinfoneeded_new

Jord,

If you want something like this considered, going to need you to provide a unified diff against trunk or at least .23 which you have applied, built, and tested yourself. The above does not look correct to me.

comment:3 Changed 11 years ago by robertm

Resolution: invalid
Status: infoneeded_newclosed

Closing this for the moment as a feature request without patch-- if you do come up with a tested patch, please feel free to reopen this ticket and we'll be happy to review it.

Note: See TracTickets for help on using tickets.