Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#7091 closed enhancement (fixed)

Modification to VideoDialog::GetFirstImage, now will recursively search for an image

Reported by: andycarr@… Owned by: robertm
Priority: minor Milestone: 0.22
Component: Plugin - MythVideo Version: head
Severity: low Keywords: mythvideo metadata
Cc: Ticket locked: yes

Description

What it does: Updates VideoDialog::GetFirstImage?, if image is not found in immediate children, it recurses into each subfolder until an image is found. Behavior is: try the files in a folder first, continue into subfolders only if no hit on files in current level.

Why it is useful: This is nice for folder structures where like content is grouped together in a "master folder". For example, multiple seasons of House, each in their own folder, are in a "House" folder in the root of the storage directory. "root->House->House Season 4". Without this patch, selecting the House folder while browsing root, no fanart is displayed (cover art was present for some items in my library however). With this patch, fanart is now available when "House" is selected.

This is my first patch submission. I tried to follow the style guide 100%, please let me know if there is anything I missed or corrections needed. Thanks!

Attachments (1)

videodlg.diff (1.8 KB) - added by andycarr@… 10 years ago.
MythVideo? videodlg.cpp diff

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by andycarr@…

Attachment: videodlg.diff added

MythVideo? videodlg.cpp diff

comment:1 Changed 10 years ago by robertm

Owner: changed from Anduin Withers to robertm
Status: newassigned

Your patch follows our style guidelines, and looks good. Thank you, I'll test and apply later.

comment:2 Changed 10 years ago by robertm

Resolution: fixed
Status: assignedclosed

(In [21932]) Fixes #7091. Allow the recursive image hunt to assign fanart/banner/screenshot/cover to a folder node when the directory structure is something like Title->Season #->Item. Now 'LOST' would show artwork even though the items with eligible metadata are two levels deeper. Original patch by Andy Carr, I added a bit to only recurse two levels deep (int maxRecurse for savvy tinkerers) and a limitation that the grandchild node title must match the grandparent node so that the above example works, but so that, for example, 'Television' isn't assigned images from 'Band of Brothers.' Also makes the TV/Movies metadata browse mode a bit more attractive. Thanks for the patch!

comment:3 Changed 10 years ago by ryan.goat@…

For me the change from 21932 is only working for Fanart images. It does not work for cover images. I am using the graphite theme. My mythvideo directory structure looks like:

root-->Entourage-->Entourage Season 2-->(.avi files)


One level up I see both cover images and fanart images. Two levels up I see fanart images and the default question mark for cover images.

Not sure if the orignal patch works for cover images or only fanart images. But changeset 21932 lists: fanart/banner/screenshot/cover. So I think they should all be working now.

mythfrontend --version

Please include all output in bug reports.
MythTV Version   : 21938M
MythTV Branch    : trunk
Network Protocol : 48
Library API      : 0.22.20090916-3
QT Version       : 4.5.0
Options compiled in:
 linux release using_oss using_alsa using_backend using_directfb using_dvb
 using_frontend using_hdhomerun using_hdpvr using_iptv using_ivtv using_joystick_menu
 using_lirc using_mheg using_opengl_video using_opengl_vsync using_qtwebkit
 using_v4l using_x11 using_xrandr using_xv using_bindings_perl using_bindings_python
 using_opengl using_vdpau using_ffmpeg_threads using_live using_mheg

comment:4 Changed 10 years ago by mike_hurley_1@…

I guess the only concern I have with this patch is that it is possible that not all seasons use the same fanart. Also, if you have complete artwork for all episodes, it seems odd to show the Season 1 cover for the show itself.

Maybe it would be better to show the fanart at the show level only if all fanart images found are the same image? I'm not saying to do a byte by byte hash, but fanart file path or basic file name/size/type. Although this idea breaks down since for me Heroes seasons 1 & 2 have the same fanart but different fanart filenames.

Another couple possibilities are to show a random fanart and no cover or keep the fanart logic the same and show no cover for the show folder.

Anybody else have any thoughts?

comment:5 Changed 10 years ago by robertm

Ticket locked: set
Note: See TracTickets for help on using tickets.