Opened 15 years ago

Closed 15 years ago

Last modified 11 years ago

#710 closed defect (fixed)

Auto skip commercials too aggressive during backwards seeks.

Reported by: bjm Owned by: cpinkham
Priority: minor Milestone: 0.19
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no


With auto skip commercials turned on, backward seeks that cross commercial boundaries can trigger unwanted forward skips. For example, Say there is a show with three minutes of commercials every ten minutes and I have JumpAmount? set to four minutes. At the ten minute mark it jumps to minute thirteen but I want to look back at something right before the commercial. I hit JUMPRWND and it shows one frame at minute nine but then immediately auto skips to thirteen again (see example "A").

0                 9 10    13            20    23
A                 v-------<

B                        v-<

It sometimes does start playing at nine but I may have to press JUMPRWND for or five times. Variations are that if I am in the middle of a commercial and hit JUMPRWND the result is a forward move to the end of the commercial break. Also if I hold SEEKRWND during a commercial, the skip back that crosses the beginning of the commercial break skips to the end and further SEEKRWNDs seek back through the entire break again.

If I let it play at thirteen for more than a few seconds then press JUMPRWND, it may find that it has crossed a boundary and needs to skip to the beginning of the next commercial break (see example "B"). Here the intent is to go back to somewhere around minute nine but instead it moves forward to minute twenty.

These are all variations of the same problem that the commercial skip code should not check if a boundary has been crossed as a result of a backward seek. I believe this started about the same time as when code was added for the SKIPCOMMBACK key to return to it's previous position if pressed shortly after SKIPCOMMERCIAL. However, this can fail too for the same reasons.

Change History (2)

comment:1 Changed 15 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [8061]) Don't AutoCommercialSkip? within 2 seconds of a manual commercial skip or normal fast-forward or rewind action. This both gives the user time to see where they are at, and also gives the player time to settle back down.

Also add in some VERBOSE VB_COMMFLAG debugging that was used in tracking this problem down.

Closes #710.

comment:2 Changed 11 years ago by shane

(In [21046]) Refs #710. Extend the "Skipping Back" window from 3 to 5 seconds.

Give the (slow) user a few more seconds to get to the remote/keyboard.

Note: See TracTickets for help on using tickets.