Opened 10 years ago

Closed 9 years ago

#7111 closed task (fixed)

subtitles in mythvideo vanish after 5 minutes

Reported by: simons.philippe@… Owned by: cpinkham
Priority: minor Milestone: 0.24
Component: MythTV - Video Playback Version: unknown
Severity: low Keywords: subtitle osd
Cc: Ticket locked: no

Description

using latest trunk, i'm gettings issues with subtitles in MythVideo?,

when enabling subtitles (.srt) for a movie, it get displayed for about 5min of the movie then they just vanish. tried to disable and re enable subtitles doest change

Attachments (2)

7111.diff (508 bytes) - added by Joe Ripley <vitaminjoe@…> 10 years ago.
Fix external subtitle reads
7111.2.diff (41.9 KB) - added by Joe Ripley <vitaminjoe@…> 10 years ago.
Sync xine_demux_sputext.cpp to xine-lib-1.1.16.2 source

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by Joe Ripley <vitaminjoe@…>

Attachment: 7111.diff added

Fix external subtitle reads

comment:1 Changed 10 years ago by Joe Ripley <vitaminjoe@…>

The issue appears to be a problem with resetting the 'emptyReads' of demuxstr. After successful reads, the variable was not getting set back to zero. The result was filling up the LINE_LEN buffer (1000 bytes) and then stopping... so you'd only see the first 1000 bytes of subtitles.

This patch fixes it for me.

Chris mentioned comparing the existing source to Xine. I'll do that next to see if there's more that needs updating.

-- Joe Ripley vitaminjoe@…

Changed 10 years ago by Joe Ripley <vitaminjoe@…>

Attachment: 7111.2.diff added

Sync xine_demux_sputext.cpp to xine-lib-1.1.16.2 source

comment:2 Changed 10 years ago by Joe Ripley <vitaminjoe@…>

Synced xine_demux_sputext.cpp to xine-lib-1.1.16.2 source. Most of the changes in the file are simply bracing, indents and whitespace. There are a couple of functional changes, but nothing that would have impacted the bug identified by this ticket.

The bug (fixed in this patch as well) was related to additions to the original xine code that allow it use the Myth RingBuffer? to read subtitle files.

I haven't tested this extensively yet, just a few quick trial runs.

-- Joe Ripley vitaminjoe@…

comment:3 Changed 10 years ago by simons.philippe@…

seems to be ok

comment:4 Changed 10 years ago by simons.philippe@…

as a side note,

I'm getting this in the mythfrontend log

Read 1142 subtitles, -2072080592 bad line(s).

comment:5 Changed 10 years ago by robertm

(In [22025]) Refs #7111. Patch from Joe Ripley to restore .srt playback in the Internal Player. We'll resync with the upstream version after the release.

comment:6 Changed 10 years ago by robertm

Component: MythTV - GeneralMythTV - Video Playback
Milestone: 0.220.23
Owner: changed from Isaac Richards to cpinkham
Severity: mediumlow
Status: newassigned
Type: defecttask

comment:7 Changed 10 years ago by cpinkham

Milestone: 0.230.24

comment:8 Changed 9 years ago by robertm

Resolution: fixed
Status: assignedclosed

The reality is that this is working, and was kept open as a reminder to resync. We don't need to keep the ticket as there's been no compelling reason to finish the job-- ASS/SSA subtitles are coming to ffmpeg so we won't need xine's lib for that, either.

Note: See TracTickets for help on using tickets.