Opened 11 years ago
Closed 10 years ago
#7111 closed task (fixed)
subtitles in mythvideo vanish after 5 minutes
| Reported by: | Owned by: | cpinkham | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.24 |
| Component: | MythTV - Video Playback | Version: | unknown |
| Severity: | low | Keywords: | subtitle osd |
| Cc: | Ticket locked: | no |
Description
using latest trunk, i'm gettings issues with subtitles in MythVideo?,
when enabling subtitles (.srt) for a movie, it get displayed for about 5min of the movie then they just vanish. tried to disable and re enable subtitles doest change
Attachments (2)
Change History (10)
comment:1 Changed 11 years ago by
The issue appears to be a problem with resetting the 'emptyReads' of demuxstr. After successful reads, the variable was not getting set back to zero. The result was filling up the LINE_LEN buffer (1000 bytes) and then stopping... so you'd only see the first 1000 bytes of subtitles.
This patch fixes it for me.
Chris mentioned comparing the existing source to Xine. I'll do that next to see if there's more that needs updating.
-- Joe Ripley vitaminjoe@…
Changed 11 years ago by
| Attachment: | 7111.2.diff added |
|---|
Sync xine_demux_sputext.cpp to xine-lib-1.1.16.2 source
comment:2 Changed 11 years ago by
Synced xine_demux_sputext.cpp to xine-lib-1.1.16.2 source. Most of the changes in the file are simply bracing, indents and whitespace. There are a couple of functional changes, but nothing that would have impacted the bug identified by this ticket.
The bug (fixed in this patch as well) was related to additions to the original xine code that allow it use the Myth RingBuffer? to read subtitle files.
I haven't tested this extensively yet, just a few quick trial runs.
-- Joe Ripley vitaminjoe@…
comment:4 Changed 11 years ago by
as a side note,
I'm getting this in the mythfrontend log
Read 1142 subtitles, -2072080592 bad line(s).
comment:5 Changed 11 years ago by
comment:6 Changed 11 years ago by
| Component: | MythTV - General → MythTV - Video Playback |
|---|---|
| Milestone: | 0.22 → 0.23 |
| Owner: | changed from Isaac Richards to cpinkham |
| Severity: | medium → low |
| Status: | new → assigned |
| Type: | defect → task |
comment:7 Changed 10 years ago by
| Milestone: | 0.23 → 0.24 |
|---|
comment:8 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
The reality is that this is working, and was kept open as a reminder to resync. We don't need to keep the ticket as there's been no compelling reason to finish the job-- ASS/SSA subtitles are coming to ffmpeg so we won't need xine's lib for that, either.
Fix external subtitle reads