Opened 11 years ago
Closed 11 years ago
#7133 closed defect (fixed)
More mythgallery fixes for windows after [21995]
Reported by: | Owned by: | Nigel | |
---|---|---|---|
Priority: | minor | Milestone: | 0.22 |
Component: | Plugin - MythGallery | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
After [21995] I still need a few more interventions to make MythGallery compile on windows, one is to fix a linker error as the MSys version of libexif is not build:
g++ -enable-stdcall-fixup -Wl,-enable-auto-import -Wl,-enable-runtime-pseudo-rel oc -Wl,-s -mthreads -Wl -shared -Wl,--out-implib,liblibmythgallery.a -o libmythg allery.dll object_script.libmythgallery -L'u:/Qt/4.5.2/lib' -lopengl32 -lglu32 -lgdi32 -luser32 -LU:/mythtv/build//lib -LU:/mythtv/build//lib -lfreetype -lmp3l ame -lmythdb-0.22 -lmythavutil-0.22 -lmythavcodec-0.22 -lmyth-0.22 -lmythui-0.22 -lmythupnp-0.22 -LU:/mythtv/build//bin -lexif -lQtSql4 -lQtXml4 -lQtOpenGL4 -lQ tGui4 -lQtNetwork4 -lQtCore4 u:/mingw-5.1.4/bin/../lib/gcc/mingw32/4.2.4/../../../../mingw32/bin/ld.exe: cann ot find -lexif collect2: ld returned 1 exit status make[1]: *** [libmythgallery.dll] Error 1 make[1]: Leaving directory `/u/mythtv/mythplugins/mythgallery/mythgallery' make: *** [sub-mythgallery-make_default] Error 2 bash.exe"-3.1$
I will attach a patch shortly, but after fixing that there is still an error because the
#if NEW_LIB_EXIF ... #else ... #endif
clauses seem to make the wrong lines of code active during compilation on windows, it uses the lines between
#else ... #endif
where it should take the instructions between
#if NEW_LIB_EXIF ... #else
Manually commenting out the offensive lines makes MythGallery compile, but I do not know how to properly make the exception in this case, so I am unable to create a patch for it, but I guess one of the more experienced developers knows how to do it.
Attachments (2)
Change History (4)
Changed 11 years ago by
Attachment: | mythgallery.patch added |
---|
Changed 11 years ago by
Attachment: | mythgallery2.patch added |
---|
comment:1 Changed 11 years ago by
Owner: | changed from Isaac Richards to Nigel |
---|---|
Status: | new → assigned |
Not sure about re-installing libexif in /mingw. I committed a simpler fix to just rename /bin/libexif.dll in [22013].
The symbol NEW_LIB_EXIF is written into mythplugins/mythgallery/mythgallery/config.h by mythplugins/configure. I think this is the default on MinGW because there is no pkg-config. If that isn't happening for you, maybe run
sh -x configure
to trace it?
comment:2 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
(In [22015]) Enable MythGallery. Closes #5992. Closes #7133. Sorry - also ups the default version number. Resulting binary only lightly tested.
Additional patch defining NEW_LIB_EXIF to compile the proper lines on windows (also fixing a minor typo in the license header in the file)