Opened 10 years ago

Closed 10 years ago

#7156 closed defect (fixed)

Unused values in libmythtv

Reported by: Erik Hovland <erik@…> Owned by: stuartm
Priority: trivial Milestone: 0.24
Component: MythTV - General Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Sometimes assignments are made but the value is never checked or used. Here are the libmythtv defects associated to this idiom.

Attachments (1)

libs_libmythtv-unused-value (1.6 KB) - added by Erik Hovland <erik@…> 10 years ago.
Remove or rework values that are assigned but never used in libmythtv

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by Erik Hovland <erik@…>

Attachment: libs_libmythtv-unused-value added

Remove or rework values that are assigned but never used in libmythtv

comment:1 Changed 10 years ago by stuartm

Milestone: unknown0.24
Owner: changed from Isaac Richards to stuartm
Status: newaccepted

comment:2 Changed 10 years ago by stuartm

Resolution: fixed
Status: acceptedclosed

(In [23968]) The variable 'widget' was being redeclared masking the earlier declaration and causing the assignment in the limited scope (if clause) to be lost. I can only assume that this code is rarely if ever reached since it never resulted in a bug that I'm aware of. Patch from Erik Hovland highlighted the problem, the other problems addressed by his patch had already been fixed. Closes #7156

Note: See TracTickets for help on using tickets.