Opened 15 years ago
Closed 14 years ago
#7158 closed defect (fixed)
Always evaluates a certain way in libmythtv
Reported by: | Owned by: | Isaac Richards | |
---|---|---|---|
Priority: | minor | Milestone: | 0.24 |
Component: | MythTV - General | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Two issues where because of the nature of the operator used the expression always evaluates a certain way. One is a bit flag for verbosity printout. The other is a bit manipulation in the MPEG tables.
Attachments (2)
Change History (8)
Changed 15 years ago by
Attachment: | libs_libmythtv-constant-expression added |
---|
comment:1 Changed 14 years ago by
The second part of Eriks patch is wrong. I think what is wanted is
psipdata()[2] = ((length>>8) & 0x0f) | (psipdata()[2] & 0xf0);
So, what you want is the top 4 bits of a 12-bit number and the top 4 bits of the existing psipdata().
comment:2 Changed 14 years ago by
That makes more sense. I will upload a new patch in the next few days. Anything to say on the first part?
Changed 14 years ago by
Attachment: | libs_libmythtv-constant-expression-ticket-7158 added |
---|
Same patch, just updated to trunk as of 2010-01-17 and has the correct fix requested in the mpeg table length bit twiddling
comment:3 Changed 14 years ago by
(In [23951]) Fix a bug in ProgramMapTable::SetProgramInfoLength?() found by Erik Hovland. We wanted to right shift length, but instead it was left shifted. This may have caused tuning problems but we haven't correlated it with any reported problems. Refs #7158
comment:4 Changed 14 years ago by
(In [23952]) Backport [23951] to 0.23-fixes. Fix a bug in ProgramMapTable::SetProgramInfoLength?() found by Erik Hovland. We wanted to right shift length, but instead it was left shifted. This may have caused tuning problems but we haven't correlated it with any reported problems. Refs #7158
comment:5 Changed 14 years ago by
(In [23953]) Backport [23951] to 0.22-fixes. Fix a bug in ProgramMapTable::SetProgramInfoLength?() found by Erik Hovland. We wanted to right shift length, but instead it was left shifted. This may have caused tuning problems but we haven't correlated it with any reported problems. Refs #7158
comment:6 Changed 14 years ago by
Milestone: | unknown → 0.24 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Fix value manipulations that always end up evaluating a certain way