Opened 10 years ago

Closed 10 years ago

#7158 closed defect (fixed)

Always evaluates a certain way in libmythtv

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: 0.24
Component: MythTV - General Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Two issues where because of the nature of the operator used the expression always evaluates a certain way. One is a bit flag for verbosity printout. The other is a bit manipulation in the MPEG tables.

Attachments (2)

libs_libmythtv-constant-expression (1.7 KB) - added by Erik Hovland <erik@…> 10 years ago.
Fix value manipulations that always end up evaluating a certain way
libs_libmythtv-constant-expression-ticket-7158 (1.7 KB) - added by Erik Hovland <erik@…> 10 years ago.
Same patch, just updated to trunk as of 2010-01-17 and has the correct fix requested in the mpeg table length bit twiddling

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by Erik Hovland <erik@…>

Fix value manipulations that always end up evaluating a certain way

comment:1 Changed 10 years ago by Paul Kendall <paul@…>

The second part of Eriks patch is wrong. I think what is wanted is

psipdata()[2] = ((length>>8) & 0x0f) | (psipdata()[2] & 0xf0);

So, what you want is the top 4 bits of a 12-bit number and the top 4 bits of the existing psipdata().

comment:2 Changed 10 years ago by Erik Hovland <erik@…>

That makes more sense. I will upload a new patch in the next few days. Anything to say on the first part?

Changed 10 years ago by Erik Hovland <erik@…>

Same patch, just updated to trunk as of 2010-01-17 and has the correct fix requested in the mpeg table length bit twiddling

comment:3 Changed 10 years ago by stuartm

(In [23951]) Fix a bug in ProgramMapTable::SetProgramInfoLength?() found by Erik Hovland. We wanted to right shift length, but instead it was left shifted. This may have caused tuning problems but we haven't correlated it with any reported problems. Refs #7158

comment:4 Changed 10 years ago by stuartm

(In [23952]) Backport [23951] to 0.23-fixes. Fix a bug in ProgramMapTable::SetProgramInfoLength?() found by Erik Hovland. We wanted to right shift length, but instead it was left shifted. This may have caused tuning problems but we haven't correlated it with any reported problems. Refs #7158

comment:5 Changed 10 years ago by stuartm

(In [23953]) Backport [23951] to 0.22-fixes. Fix a bug in ProgramMapTable::SetProgramInfoLength?() found by Erik Hovland. We wanted to right shift length, but instead it was left shifted. This may have caused tuning problems but we haven't correlated it with any reported problems. Refs #7158

comment:6 Changed 10 years ago by stuartm

Milestone: unknown0.24
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.