Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#7167 closed defect (fixed)

Check the return value of function calls inside of mythfrontend

Reported by: Erik Hovland <erik@…> Owned by: stuartm
Priority: trivial Milestone: 0.24
Component: MythTV - General Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Quite a few UI and configuration calls return a value. Maybe they should be checked?

Attachments (4)

programs_mythfrontend-check-return (9.8 KB) - added by Erik Hovland <erik@…> 10 years ago.
Check the return value of calls in mythfrontend
programs_mythjobqueue-check-return (739 bytes) - added by Erik Hovland <erik@…> 10 years ago.
Same kind of return value checking in mythjobqueue
programs_mythlcdserver-check-return (1.8 KB) - added by Erik Hovland <erik@…> 10 years ago.
Check the return value of dup2
programs_mythtv-setup-check-return (1.0 KB) - added by Erik Hovland <erik@…> 10 years ago.
Check some return values in mythtv-setup

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by Erik Hovland <erik@…>

Check the return value of calls in mythfrontend

Changed 10 years ago by Erik Hovland <erik@…>

Same kind of return value checking in mythjobqueue

Changed 10 years ago by Erik Hovland <erik@…>

Check the return value of dup2

Changed 10 years ago by Erik Hovland <erik@…>

Check some return values in mythtv-setup

comment:1 Changed 10 years ago by stuartm

I'd sooner remove the return value of BuildFocusList?() than add all those checks. The only time we return false would is when we're missing focusable widgets and that's perfectly valid if the screen works without them. If the screen doesn't work without them then it's a code error, the author has failed to check that the required widgets exist in the theme. So altogether it's redundant for BuildFocusList?() to return any value at all.

comment:2 Changed 10 years ago by stuartm

Milestone: unknown0.24
Owner: changed from Isaac Richards to stuartm
Status: newaccepted

Erik, BuildFocusList? no longer returns true/false, so the frontend patch needs updating.

comment:3 Changed 10 years ago by stuartm

(In [23967]) Always check the return of ConnectToMasterServer?() in programs/. Patch from Erik Hovland. Refs #7167

comment:4 Changed 10 years ago by stuartm

Status: acceptedinfoneeded

comment:5 Changed 9 years ago by robertm

Resolution: fixed
Status: infoneededclosed

No update. (Please feel free to reopen if you get around to this).

comment:6 Changed 9 years ago by Erik Hovland <erik@…>

No sweat. I do have a patch. But I will have to see what it does currently. Thanks for keeping up w/ the ticket.

Note: See TracTickets for help on using tickets.