Opened 11 years ago

Closed 11 years ago

#7170 closed defect (fixed)

Raft of mythtranscode defects to fix

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: MythTV - Mythtranscode Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Tracks all defect patches to mythtranscode. Including replex defects.

  1. Negative return values foul later calls
  2. Check pointers in replex
  3. Evaluation order is muddled in replex
  4. pointer checking in mythtranscode
  5. Initialization defects in mythtranscode

Attachments (6)

programs_mythtranscode-negative-returns​ (2.1 KB) - added by Erik Hovland <erik@…> 11 years ago.
Check possible negative return values before feeding to functions that can't handle negative values
programs_mythtranscode_replex_replex.c-fix-unchecked-null-of-apes_abort​ (781 bytes) - added by Erik Hovland <erik@…> 11 years ago.
Check null in replex
programs_mythtranscode_replex-negative-return​ (4.6 KB) - added by Erik Hovland <erik@…> 11 years ago.
Check negative return values
programs_mythtranscode_replex_element.c-evaluation-order​ (1.1 KB) - added by Erik Hovland <erik@…> 11 years ago.
Make evaluation order explicit in replex
programs_mythtranscode-pointer-checking​ (831 bytes) - added by Erik Hovland <erik@…> 11 years ago.
Check pointers in mythtranscode
programs_mythtranscode-uninit​ (2.0 KB) - added by Erik Hovland <erik@…> 11 years ago.
Initialize variables in mythtranscode

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by Erik Hovland <erik@…>

Attachment: programs_mythtranscode-negative-returns​ added

Check possible negative return values before feeding to functions that can't handle negative values

Changed 11 years ago by Erik Hovland <erik@…>

Attachment: programs_mythtranscode_replex_replex.c-fix-unchecked-null-of-apes_abort​ added

Check null in replex

Changed 11 years ago by Erik Hovland <erik@…>

Attachment: programs_mythtranscode_replex-negative-return​ added

Check negative return values

Changed 11 years ago by Erik Hovland <erik@…>

Attachment: programs_mythtranscode_replex_element.c-evaluation-order​ added

Make evaluation order explicit in replex

Changed 11 years ago by Erik Hovland <erik@…>

Attachment: programs_mythtranscode-pointer-checking​ added

Check pointers in mythtranscode

Changed 11 years ago by Erik Hovland <erik@…>

Attachment: programs_mythtranscode-uninit​ added

Initialize variables in mythtranscode

comment:1 Changed 11 years ago by robertm

Resolution: → fixed
Status: new → closed

(In [25510]) Various fixes for mythtranscode from Erik Hovland. At the time of the patches on the ticket, a replex resync was applied that was reverted, so these are the cherry-picked fixes of what is still relevant. One or two of the fixes were made in a slightly different way over the past ten months, so those are excluded as well. Seems fine in my testing. Thanks to Erik for the patches, fixes #7170.

Note: See TracTickets for help on using tickets.