Opened 11 years ago
Closed 11 years ago
#7197 closed defect (fixed)
Changing channels in LiveTV won't switch to an other input
Reported by: | joepadmiraal | Owned by: | Shane Shrybman |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | MythTV - DVB | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
I have 2 dvb-s2 cards which both have 4 satellites attached to it. I don't have a problem when I switch channels by typing in the channel number and pressing SELECT. When I use the UP and DOWN button to go to a channel which is on an other input and press SELECT, the channel is not changed correctly. In stead of going to the channel on the other input, it is going to the first channel of the current input. This description looks a lot like ticket #6208. However the patch supplied in that ticked did not solve my problem. I did find the solution to my problem and attached a patch to this ticked.
Attachments (1)
Change History (5)
Changed 11 years ago by
Attachment: | switchInput.diff added |
---|
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
Owner: | changed from Janne Grunau to Shane Shrybman |
---|---|
Priority: | major → minor |
Severity: | medium → low |
Status: | new → accepted |
Hi, thanks for your report and the patch. Please give the patch on #6208 a try.
comment:3 Changed 11 years ago by
Tested the last patch from #6208. This does also solve my problem.
At first I was actually thinking about the same solution as this patch offering. I placed a question about the call to ´CommitQueuedInput?´ on the mythtv-dev mailing list. Sadly I did not get any answers to my question ;)
I think it would be very useful to the waf factor to add my patch, or the patch from #6208 to the 0.22 release.
comment:4 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
(In [22346]) Fixes #7197 and #6208. Fix LiveTV browsing to channels on other inputs.
Remove the call to CommitQueuedInput?() when selecting a channel in browse mode. BrowseEnd?(ctx, true) will do the call to ChangeChannel?(..).
This problem was only seen if the "Browse all channels" option was turned off.
This ticked should be a patch in stead of a defect. I also tested the patch on an other machine with a single skystar2 dvb-s card.
The problem exists for at least a few months in the trunk version. Here is the version info of the test machine with the 2 dvb-s2 cards.
For some reason, the function TV::BrowseHandleAction? makes a call to CommitQueuedInput? after it has determined that a SELECT action is in the actions list. TV::CommitQueuedInput? makes an other call to BrowseChannel?, even if GetQueuedChanNum? return's no queued channel. This last issue is the part I adjusted in the patch. Please let me know if this is the right place to deal with the problem.