Changing channels in LiveTV won't switch to an other input

[joepadmiraal]

I have 2 dvb-s2 cards which both have 4 satellites attached to it. I don't have a problem when I switch channels by typing in the channel number and pressing SELECT. When I use the UP and DOWN button to go to a channel which is on an other input and press SELECT, the channel is not changed correctly. In stead of going to the channel on the other input, it is going to the first channel of the current input. This description looks a lot like ticket #6208. However the patch supplied in that ticked did not solve my problem. I did find the solution to my problem and attached a patch to this ticked.

[joepadmiraal]

This ticked should be a patch in stead of a defect. I also tested the patch on an other machine with a single skystar2 dvb-s card.

The problem exists for at least a few months in the trunk version. Here is the version info of the test machine with the 2 dvb-s2 cards.

joep@server1:~> mythfrontend --version
Please include all output in bug reports.
MythTV Version   : 22097M
MythTV Branch    : trunk
Network Protocol : 48
Library API      : 0.22.20090928-1
QT Version       : 4.5.2
Options compiled in:
 linux release using_oss using_backend using_dvb using_frontend using_hdhomerun using_hdpvr using_iptv using_ivtv using_joystick_menu using_lirc using_mheg using_opengl_video using_opengl_vsync using_qtwebkit using_v4l using_x11 using_xrandr using_xv using_xvmc using_xvmc_vld using_xvmcw using_bindings_perl using_bindings_python using_opengl using_ffmpeg_threads using_live using_mheg

For some reason, the function TV::BrowseHandleAction? makes a call to CommitQueuedInput? after it has determined that a SELECT action is in the actions list. TV::CommitQueuedInput? makes an other call to BrowseChannel?, even if GetQueuedChanNum? return's no queued channel. This last issue is the part I adjusted in the patch. Please let me know if this is the right place to deal with the problem.

[Shane Shrybman]

Hi, thanks for your report and the patch. Please give the patch on #6208 a try.

[joepadmiraal]

Tested the last patch from #6208. This does also solve my problem.

At first I was actually thinking about the same solution as this patch offering. I placed a question about the call to ´CommitQueuedInput?´ on the mythtv-dev mailing list. Sadly I did not get any answers to my question ;)

I think it would be very useful to the waf factor to add my patch, or the patch from #6208 to the 0.22 release.

[shane]

(In [22346]) Fixes #7197 and #6208. Fix LiveTV browsing to channels on other inputs.

Remove the call to CommitQueuedInput?() when selecting a channel in browse mode. BrowseEnd?(ctx, true) will do the call to ChangeChannel?(..).

This problem was only seen if the "Browse all channels" option was turned off.