Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#7203 closed patch (fixed)

More transcode parameter changes

Reported by: Marc Randolph <mrand@…> Owned by: Anduin Withers
Priority: minor Milestone: 0.22
Component: Plugin - MythVideo Version: head
Severity: low Keywords: mtd transcode
Cc: Ticket locked: no

Description

Per http://hg.berlios.de/repos/tcforge/file/d6956f8dca76/docs/CHANGES-1.0-1.1, the 1.1.x released branch of transcode has done away with the "color" argument and replaced it with --log_no_color

The --use_rgb (aka '-1') option has also changed again (this was touched recently in Bug #6807). Confusingly, mtd/jobthread.cpp put this option on the command line when "use_yv12" is set in mythconverg, which causes transcode to use the CODEC_RGB. This is confusing because comments within transcode source refer to RGB as something different than YV12.

If we really need this option, it has been replaced with "--video_format rgb24" Removing this option altogether will change transcode to use the default setting of yuv240p.

Unfortunately, their changes are not compatible to older versions of transcode which most people are running right now (but distributions are moving to the new one this fall), so changing it could create backward compatibility problem for those that don't upgrade their version of transcode - hence this patch which adds a option to the configure script for the newer versions of transcode.

If patch is adopted, it requires re-running configure regardless if you are on old or new transcode (to generate the config.h).

If it is preferred to try to auto-detect the version of transcode that is installed, I could take a stab at that.

Attachments (1)

new-transcode-v1.patch (3.1 KB) - added by Marc Randolph <mrand@…> 10 years ago.
Adds configure script option to allow for newer versions of transcode to work

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Marc Randolph <mrand@…>

Attachment: new-transcode-v1.patch added

Adds configure script option to allow for newer versions of transcode to work

comment:1 Changed 10 years ago by robertm

Milestone: 0.220.23
Severity: mediumlow
Type: defectpatch

Mark,

For a transitory upgrade, I don't think changes to the configure script are a good idea. mythdvd either needs to detect the running version of transcode, or this needs to be postponed until most distros are running the new version of transcode.

comment:2 Changed 10 years ago by robertm

Resolution: fixed
Status: newclosed

(In [22358]) Fixes #7279. Fixes #7203. Update mtd to support command line commands for transcode versions 1.0 and 1.1. Fix colorspace issues. I was able to create correctly colored transcodes with both versions. If anything is still amiss, please open a new ticket with log output from mtd.

comment:3 Changed 10 years ago by stuartm

Milestone: 0.230.22
Note: See TracTickets for help on using tickets.