Opened 14 years ago

Closed 14 years ago

#736 closed patch (fixed)

Move Decoder lock/unlock from mutex into Decoder and small fixes to playbackbox

Reported by: eskil <myth@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythmusic Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Another patch to keep the shoutcast patch small. The main part of this patch is moving locking/unlocking of a decoder up to be a method in Decoder. This means that code like ;

decoder->mutex()->lock();

becomes

decoder->lock();

The purpose is to allow decoders to do special things on locking. Ie. the shoutcast decoder will have two locks (it's own and the decoder it's using).

And some changes to playbackbox.

  • Don't display total time if playing something that has no total time
  • add a updateTrackInfo that updates the UI elements and the LCD (when streaming the metadata will change during playback).
  • move opening the output out to a seperate method, just to keep PlaybackBox::play() simpler.

Also indent streaminput.cpp.

Attachments (1)

decoderlocking.patch (23.6 KB) - added by eskil <myth@…> 14 years ago.
patch file

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by eskil <myth@…>

Attachment: decoderlocking.patch added

patch file

comment:1 Changed 14 years ago by anonymous

The patch requires the observable.2.patch from ticket:655.

comment:2 Changed 14 years ago by anonymous

This patch seems to be missing the "stopDecoder" method.

comment:3 Changed 14 years ago by eskil <myth@…>

Nope, that method is already defined in PlaybackBox, I just removed code from stop() and replaced with a call to stopDecoder.

comment:4 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [8177]) Close #736 (minor music code cleanups) by applying patch.

Note: See TracTickets for help on using tickets.