Opened 11 years ago

Closed 11 years ago

#7372 closed defect (fixed)

MythDB overriddenSettings access is not thread-safe.

Reported by: danielk Owned by: danielk
Priority: major Milestone: unknown
Component: MythTV - General Version: head
Severity: medium Keywords:
Cc: Ticket locked: no


Not only not thread-safe, but the code could be more efficient as well by putting these overridden settings in the settingsCache when they are created.

Attachments (1)

7372-v1.patch (15.8 KB) - added by danielk 11 years ago.

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by danielk

Attachment: 7372-v1.patch added

comment:1 Changed 11 years ago by danielk

This patch has not been extensively tested nor has it been benchmarked, use at your own risk.

comment:2 Changed 11 years ago by danielk

Resolution: fixed
Status: newclosed

(In [22779]) Fixes #7372. Makes overriddenSettings use thread-safe.

This also squeezes strings before adding them to the cache to reduce the memory footprint and uses a read-write lock for less blocking when multiple threads use the settings cache at once.

This updates the binary revision, so plugins need to be rebuilt.

Note: See TracTickets for help on using tickets.