Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#7406 closed defect (fixed)

MythCenter EPG - cannot change channel

Reported by: kbass@… Owned by: sphery
Priority: minor Milestone: 0.22.1
Component: MythTV - General Version: 0.22rc1
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I'm using MythCenter? theme, in the previous version I would hit M to bring up the EPG, scroll the listings, and select M to change to the selected channel. That no longer works. (Even though X works to change a channel without exiting the EPG).

The current keys.txt still says:

  • Pressing M when on a channel will change to that channel.

Is this supposed to have changed? If so, the documentation is incorrect. If not, there is a bug.

Browse mode seems to still work. I have not tested the other themes to see if the same behaviour exists.

Change History (6)

comment:1 Changed 10 years ago by sphery

(In [22674]) Refs #7406. Fix channel change in the EPG. After this commit, SELECT changes the channel and dismisses the EPG when watching LiveTV and the selected show's starttime is less than now + SelChangeRecThreshold?. Users who prefer to always edit a schedule should use the EDIT keybinding or access "Edit Schedule" through the MENU.

In the mythui port of guidegrid, the MENU key was changed to show the menu (as it should). Unfortunately since prior to this change MENU was used to change the channel and dismiss the EPG, this meant that the only way to change channel and dismiss the EPG when in LiveTV was to enable SelectChangesChannel? and use the SELECT key. Since the use of the MENU key to change channels doesn't fit the UI consistency guidelines, it makes sense to just remove the SelectChangesChannel? setting and always use its functionality.

This change also fixes SELECT so that it does not attempt to change the channel if not watching LiveTV (when using the alternate EPG while playing back a recording). Furthermore, to ensure all functionality is always available in spite of SELECT's dual-usage, it adds "Change Channel" to the menu when watching LiveTV and adds "Edit Recording Status" to the menu for shows that match a recording rule (where "Edit Recording Status" is the function SELECT gives for a show that matches a rule and starts after SelChangeRecThreshold? minutes--the "allow you to resolve conflicts or change overrides" in keys.txt).

I will backport this change to 0.22-fixes after 0.22 is released. Until then users should enable the setting, "Use select to change the channel in the program guide" or use the CHANUPDATE keybinding (by default, 'X') to change the channel and then dismiss the EPG with ESCAPE.

comment:2 Changed 10 years ago by sphery

Milestone: unknown0.22.1
Owner: changed from Isaac Richards to sphery
Priority: majorminor
Status: newaccepted

comment:3 Changed 10 years ago by sphery

(In [22823]) Update the HOWTO's Keyboard commands section for new EPG behavior after [22674]. Refs #7406.

comment:4 Changed 10 years ago by sphery

Resolution: fixed
Status: acceptedclosed

(In [22824]) Fixes #7406. Fix channel change in the EPG. Backports [22674] and [22823] from trunk.

comment:5 Changed 10 years ago by sphery

(In [23033]) Clarify the help text for the "Record Threshold" setting after [22674]. Refs #7406.

Thanks to Joacim J on the -users list for helping to find the out-of-date help text.

comment:6 Changed 10 years ago by sphery

(In [23034]) Clarify the help text for the "Record Threshold" setting after [22824]. Backports [23033] to -fixes. Refs #7406.

Note: See TracTickets for help on using tickets.