Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#7425 closed patch (fixed)

Mythvideo doesn't properly behaves with "Video Tree remembers last position" flag

Reported by: jyavenard Owned by: paulh
Priority: minor Milestone: 0.25
Component: Plugin - MythVideo Version: head
Severity: low Keywords:
Cc: Ticket locked: yes

Description

Mythvideo can be set to remember the last position when exiting.
So when you go back into mythvideo you are were you last left.

The setting:
Setup -> Media Settings -> Videos -> General Settings -> Page 2
"Video tree remembers last position"

When going into Mythvideo, always back at the root of the directory.

Gallery view or Listing view

Attachments (4)

0001-Fixes-7425.-Update-tree-position-remmeber-functiona.patch (2.1 KB) - added by mythtv@… 4 years ago.
Fixes "Save tree position" functionality in MythVideo?
0001-Fixes-7425 - updated.patch (5.0 KB) - added by mythtv@… 4 years ago.
mythvideo-remember-tree-and-gallery-position.patch (7.3 KB) - added by Robert S 4 years ago.
Remember video position also in gallery view mode
mythvideo-remember-tree-position.patch (4.6 KB) - added by Robert S 4 years ago.
Improved patch against trunk 24740

Download all attachments as: .zip

Change History (23)

comment:1 Changed 4 years ago by robertm

  • Component changed from MythTV - General to Plugin - MythVideo
  • Milestone changed from 0.22 to unknown
  • Owner changed from ijr to awithers
  • Severity changed from medium to low
  • Version changed from 0.22rc1 to head

comment:2 Changed 4 years ago by jyavenard

Then that option should be removed from the settings if it doesn't do anything in 0.22

comment:3 Changed 4 years ago by rjmyst3@…

Please don't remove the setting, but fix it instead.

I have a large video collection stored in a hierarchy of folders, and re-navigating every time I switch between videos and recordings is frustrating (more-so because my wife complains).

I really enjoyed that setting, and I am currently subscribed to updates from the 0.22-fixes through mythbuntu, so if it got fixed I could appreciate it immediately.

Is anyone able to work on this? Is this something I could reasonable create a patch for if I were to download/compile the source?

comment:4 Changed 4 years ago by robertm

  • Ticket locked set

Discussion belongs on mailing lists.

Changed 4 years ago by mythtv@…

Fixes "Save tree position" functionality in MythVideo?

Changed 4 years ago by mythtv@…

comment:5 Changed 4 years ago by jyavenard

  • Ticket locked unset

comment:6 Changed 4 years ago by anonymous

I am very interested in this patch, since this feature is beyond useful to me, and I've missed it dearly in 0.22-fixes. If I can help out by testing it, let me know what I need to do (in 20 words or less, I'll figure out the details.) Thanks.

comment:7 Changed 4 years ago by oobe.trouble@…

Hi thanks heaps for the patch i tried it but it didnt seem to work

comment:8 Changed 4 years ago by anonymous

I just applied this to 0.22-fixes and it worked great. Thanks.

comment:9 Changed 4 years ago by paulh

  • Milestone changed from unknown to 0.23
  • Type changed from defect to patch

comment:10 follow-up: Changed 4 years ago by robertm

  • Milestone changed from 0.23 to 0.24

comment:11 in reply to: ↑ 10 Changed 4 years ago by Robert S

The attached patch is against trunk revision 24017.
It includes the patch from above but expands the functionality.
The video position is now also remembered for the gallery view (which I use).

Robert S

Changed 4 years ago by Robert S

Remember video position also in gallery view mode

Changed 4 years ago by Robert S

Improved patch against trunk 24740

comment:12 Changed 4 years ago by robertm

  • Milestone changed from 0.24 to unknown

comment:13 Changed 4 years ago by robertm

  • Owner changed from awithers to robertm
  • Status changed from new to assigned

comment:14 Changed 4 years ago by robertm

  • Milestone changed from unknown to 0.25

comment:15 Changed 4 years ago by stuartm

  • Milestone 0.25 deleted

Milestone 0.25 deleted

comment:16 Changed 3 years ago by oobe.trouble@…

Do any of these patches work with .24 fixes i tryed mythvideo-remember-tree-position.patch which applied cleanly but it didnt seem to work and 0001-Fixes-7425 - updated.patch doesnt apply cleanly which is what i was using with .23 fixes.

comment:17 Changed 3 years ago by robertm

  • Ticket locked set

Oobe, you've been spoken to about ignoring trac rules before.

comment:18 Changed 3 years ago by Github

  • Resolution set to fixed
  • Status changed from assigned to closed

MythVideo?: Fix the remember position setting.

This fixes the setting to restore the same position in browser, gallery and
tree views when returning to MythVideo? or when switching views. Fixes #7425.

Branch: master
Changeset: b03a6b6acecaf1dbd6b28c3d0ca75a66a6f0feaa

comment:19 Changed 3 years ago by paulh

  • Owner changed from robertm to paulh

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.