Opened 10 years ago

Closed 10 years ago

#7475 closed defect (fixed)

[PATCH] Trivial, Ok->OK nit in mythfrontend

Reported by: Reynaldo H. Verdejo Pinochet Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: MythTV - General Version: head
Severity: low Keywords: Ok, OK
Cc: Ticket locked: yes

Description

As in subject, I'm almost sure this is OK (:) Patch attached.

Attachments (1)

FrontendOK_20091101.diff (942 bytes) - added by Reynaldo H. Verdejo Pinochet 10 years ago.
As in $Subject. Please review and apply if correct.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Reynaldo H. Verdejo Pinochet

Attachment: FrontendOK_20091101.diff added

As in $Subject. Please review and apply if correct.

comment:1 Changed 10 years ago by anonymous

You do realize that you break all the translations by doing that?

comment:2 Changed 10 years ago by robertm

Ticket locked: set

Translations needing updates is not a valid reason to keep incorrect language/terminology. Discussion belongs on lists.

comment:3 Changed 10 years ago by stuartm

Better yet, remove the SetText?()s, it's a static string, let the theme handle it.

comment:4 Changed 10 years ago by robertm

Resolution: fixed
Status: newclosed

(In [23120]) Fixes #7475. Remove static setting of button text in proglist.cpp to be in line with our UI coding guidelines (with few exceptions, individual button text should not be set in code, but left to the themer).

Note: See TracTickets for help on using tickets.