Opened 10 years ago

Closed 10 years ago

#7547 closed defect (fixed)

ttvdb.py script fails to locate season banners if no poster available

Reported by: Robin Hill <myth@…> Owned by: Anduin Withers
Priority: minor Milestone: unknown
Component: Plugin - MythVideo Version: 0.22
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I've noticed that a number of series (for which I've added DVD cover images to TVDB) were failing to download these when updating metadata. I've looked into this and it would seem to be due to a discrepancy between posters and banners. The cover image is actually a banner, but the script is skipping checking for this unless a poster has been found (several series have season banners but no posters). The attached patch fixes this - it moves the check for a poster until after checking for a season banner.

Attachments (1)

ttvdb_season_banner_fix.py (1.5 KB) - added by Robin Hill <myth@…> 10 years ago.
Patch for ttvdb.py

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Robin Hill <myth@…>

Attachment: ttvdb_season_banner_fix.py added

Patch for ttvdb.py

comment:1 Changed 10 years ago by r.d.vaughan@…

Robin, I am happy for anyone to contribute so thanks for the patch. I have looked over the current ttvdb.py and do not see what would cause this issue. Please provide an example(s) TV series, season and episode that has this issue. The problem may also effect other scripts such as Jamu. Multiple example TV series is best.

Thanks

comment:2 Changed 10 years ago by Robin Hill <myth@…>

Sure, examples of those with only season banners (with TTVDB IDs) are:

Journeys to the Bottom of the Sea (121331)
Victoria's Empire (81409)
Fred Dibnah's Age of Steam (97921)

and one which does retrieve the season banner as there's also a poster:

Russell Howard's Good News (120541)


Running "ttvdb -P" with the first three will fail to retrieve the season posters (without the patch), whereas the fourth one will retrieve the season poster okay in either case.

comment:3 Changed 10 years ago by robertm

Resolution: fixed
Status: newclosed

(In [22804]) Fixes #7547. Patch from Doug Vaughan to fix both season coverart and banner URLs being returned when there is no series images of the same types. Issue is not present in trunk due to new grabber script format changes.

Note: See TracTickets for help on using tickets.