Opened 10 years ago

Closed 10 years ago

#7550 closed enhancement (wontfix)

Icon download should allow forced custom search

Reported by: scottadmi@… Owned by: Isaac Richards
Priority: minor Milestone: 0.24
Component: MythTV - Mythtv-setup Version: 0.22
Severity: low Keywords:
Cc: Ticket locked: no

Description

Currently, there is no way to force a manual search for a channel icon download if one is automatically selected for a channel. This causes problems if an incorrect one is automatically assigned to channel and you want to enter the screen to select from options by hand. A good resolution would be to leave the existing behavior as is for choosing download all icons or rescan for missing icons, but if "Download icon for <channel>" is selected from the popup, it could force it to go to the manual search/selection screen to allow correction of incorrect icons which were auto-selected.

Fix to implement this:

In programs/mythtv-setup/importicons.cpp - line 368.

Replace

if (!findmissing((*m_iter).strIconCSV))

With

if (!findmissing((*m_iter).strIconCSV) || !name.isEmpty())

This forces custom searching on single channel icon download.

Change History (4)

comment:1 Changed 10 years ago by Stuart Auchterlonie

Milestone: 0.22.10.23

comment:2 Changed 10 years ago by robertm

Milestone: 0.230.24

Bumping enhancement patch to next release.

comment:3 Changed 10 years ago by stuartm

Can you post the incorrect icon matches to the mailing list so that we can fix them? We need the row from the channel table for each.

comment:4 Changed 10 years ago by robertm

Resolution: wontfix
Status: newclosed

Upon rereading this, I am not convinced that the solution is a good idea. There are all sorts of scenarios under which one would want to download icons (using the autodetection) for individual channels. Implementing your idea would mean they would have to go through the manual search each and every time, and that doesn't sound like a lot of fun. I think the only way something like this should go in would be as a separate button/menu option. If you feel like implementing something like that, please re-open and attach a patch. Also, if you would help us out by providing the problem channels to the dev list as Stuart asked above, that would be appreciated.

Note: See TracTickets for help on using tickets.