Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#7633 closed defect (fixed)

Default new recording end offset is set to DefaultStartOffset pref, should be DefaultEndOffset

Reported by: mythtv@… Owned by: gigem
Priority: minor Milestone: 0.23
Component: MythTV - Scheduling Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This seems to have been broken in the transition from ScheduledRecording? to RecordingRule? classes (based on my quick check of the SVN logs).

I think this is a trivial fix.

--- mythtv-trunk/mythtv/libs/libmythtv/recordingrule.cpp        (revision 22880)
+++ mythtv-trunk/mythtv/libs/libmythtv/recordingrule.cpp        (working copy)
@@ -26,7 +26,7 @@
     m_recPriority(0),
     m_prefInput(0),
     m_startOffset(gContext->GetNumSetting("DefaultStartOffset", 0)),
-    m_endOffset(gContext->GetNumSetting("DefaultStartOffset", 0)),
+    m_endOffset(gContext->GetNumSetting("DefaultEndOffset", 0)),
     m_dupMethod(static_cast<RecordingDupMethodType>(
                 gContext->GetNumSetting("prefDupMethod", kDupCheckSubDesc))),
     m_dupIn(kDupsInAll),

Change History (3)

comment:1 Changed 10 years ago by Stuart Auchterlonie

Milestone: unknown0.23

comment:2 Changed 10 years ago by sphery

Resolution: fixed
Status: newclosed

(In [23108]) Fix the DefaultEndOffset? in recordingrule.cpp (a copy/paste typo from [21745]). Fixes #7633.

comment:3 Changed 10 years ago by sphery

(In [23110]) Fixes #7633. Fix the DefaultEndOffset? in recordingrule.cpp. Backports [23108] from trunk.

Thanks to Rob Mueller for the ticket and patch.

Note: See TracTickets for help on using tickets.