Opened 10 years ago

Closed 10 years ago

#7639 closed defect (fixed)

DVD: audio streams get the 'Unknown language' in audio track map

Reported by: linux@… Owned by: skamithi
Priority: minor Milestone: unknown
Component: MythTV - General Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi,

I noticed that with the DVDs I checked the codec did not set the audio language code in 'AvFormatDecoder::ScanStreams?' resulting in the audio streams being saved in 'Unknown Language' internally. This does not seem to be a bigger issue as the OSD gets its information about the tracks directly via dvdnav and not via the track map.

I added some code to get the language info for the track map via dvdnav as well in case of DVDs and created a patch for this.

When testing the patch I ran into a bug that was shadowed by all audio tracks always having the unknown language: the stream selection in 'AvFormatDecoder::AutoSelectAudioTrack?' exited early in case the audio map contained more than 1 language. I fixed this as well as part of the patch as it will only create more problems otherwise.

The patch is against release-0-22-fixes.

Please let me know if you need more information or testing.

Best wishes,

Martin.

Attachments (2)

dvdlanguageselection.patch (1.4 KB) - added by linux@… 10 years ago.
patch to get the language code for DVD stream via dvdnav
dvd-audio-language-detection (1.2 KB) - added by linux@… 10 years ago.
update patch to determine audio track number via DVDRingBuffer::GetAudioTrackNum?

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by linux@…

Attachment: dvdlanguageselection.patch added

patch to get the language code for DVD stream via dvdnav

comment:1 Changed 10 years ago by skamithi

Owner: changed from Isaac Richards to skamithi
Status: newassigned

Changed 10 years ago by linux@…

update patch to determine audio track number via DVDRingBuffer::GetAudioTrackNum?

comment:2 Changed 10 years ago by skamithi

(In [23164]) Refs #7639. resolve problem where audio streams show up as "unknown language" in the audio track map. patch from martin kittel. will apply to 0.22 fixes soon.

comment:3 Changed 10 years ago by skamithi

Resolution: fixed
Status: assignedclosed

(In [23426]) Closes #7639. apply [23164] to 0.22 fixes. resolve problem where audio streams show up as "unknown language" in the audio track map. patch from martin kittel

Note: See TracTickets for help on using tickets.