Opened 10 years ago

Closed 10 years ago

#7640 closed defect (fixed)

DVD: switching audio track via OSD does not update DVD preferences

Reported by: linux@… Owned by: skamithi
Priority: minor Milestone: unknown
Component: MythTV - General Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi,

when testing some other stuff I stumbled over the following problem:

when I set the audio track of a DVD via 'Select Audio Track' using the OSD the 'DVDRingBufferPriv' structure is not updated. Because of this the internal player will switch back to the default audio track that was selected via the DVD menu whenever 'AvFormatDecoder::ScanStreams?' gets called (as was the case in my example, where I had a DVD on which a number of new streams were found in the course of the first few minutes of the feature film).

I added a patch that updates the state correctly in the NuppelVideoPlayer? as to me it seems there is no way to cleanly do this anywhere in avformatdecoder.cpp. The patch is against release-0-22-fixes.

Please let me know if you need more information or testing.

Best wishes,

Martin.

Attachments (3)

dvdlanguageselection1.patch (611 bytes) - added by linux@… 10 years ago.
patch to update selected language in 'DVDRingBufferPriv'
dvdnav_set_active_audio_stream.patch (3.4 KB) - added by skamithi 10 years ago.
you go to the DVD menu and then back to the movie, the audio track would get reset to the internal dvdnav vm's default. this path from martin kittel keeps it at the audio track you selected from the osd.
remove-m_autoselectaudio.patch (2.0 KB) - added by linux@… 10 years ago.
remove m_autoselectaudio from DVDRingBuffer as it has become superfluous now that the dvdnav vm tracks the users choices

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by linux@…

Attachment: dvdlanguageselection1.patch added

patch to update selected language in 'DVDRingBufferPriv'

comment:1 Changed 10 years ago by skamithi

Owner: changed from Isaac Richards to skamithi
Status: newassigned

comment:2 Changed 10 years ago by skamithi

(In [22949]) Refs #7640. internal dvd player: switching audio track via osd doesn't update dvd preferences..patch from martin kittel.

comment:3 Changed 10 years ago by skamithi

(In [23003]) Refs #7640. apply [22949] to 0.22 fixes. internal dvd player: switching audio track via osd doesn't update dvd preferences.

Changed 10 years ago by skamithi

you go to the DVD menu and then back to the movie, the audio track would get reset to the internal dvdnav vm's default. this path from martin kittel keeps it at the audio track you selected from the osd.

comment:4 Changed 10 years ago by skamithi

(In [23049]) Refs #7640. internal dvd player .when a change in the audio track is made using the OSD, it sets this new audio track setting to be the dvd default audio track.

Changed 10 years ago by linux@…

remove m_autoselectaudio from DVDRingBuffer as it has become superfluous now that the dvdnav vm tracks the users choices

comment:5 Changed 10 years ago by skamithi

(In [23080]) Refs #7640. Remove m_autoselectaudio var from internal dvd player code. not needed anymore. better solution provided by Martin Kittel.

comment:6 Changed 10 years ago by skamithi

(In [23081]) Refs #7640. Apply [23049] to 0.22 fixes. internal dvd player .when a change in the audio track is made using the OSD, it sets this new audio track setting to be the dvd default audio track.

comment:7 Changed 10 years ago by skamithi

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.