Opened 10 years ago

Closed 10 years ago

#7651 closed patch (wontfix)

Patch to jamu.py to allow the removal of certain words from genres from TMDB

Reported by: Mathieu Brabant <Mathieu@…> Owned by: Anduin Withers
Priority: minor Milestone: unknown
Component: Plugin - MythVideo Version: head
Severity: medium Keywords: jamu tmdb genres
Cc: Ticket locked: no

Description

This patch will add one configuration option, tmdb_genre_remove_word, which will remove some words from genres returned by TMDB.

For example, TMDB often uses the words "film" and "movie" in their genres. IMDB does not, so when we have a combination of metadata from both sources, we end up with a list of genres that looks like this: "Comedy", "Comedy Film", "Animation", "Animation Film". It looks messy when browsing by genre in MythVideo?.

With this patch, adding the option "tmdb_genre_remove_word: film,movie" to the configuration file would only clean this.

Attachments (1)

jamu-genre_remove_word.patch (1.9 KB) - added by Mathieu Brabant <Mathieu@…> 10 years ago.
Patch to allow the removal of certain words from the genres returned by TMDB

Download all attachments as: .zip

Change History (2)

Changed 10 years ago by Mathieu Brabant <Mathieu@…>

Patch to allow the removal of certain words from the genres returned by TMDB

comment:1 Changed 10 years ago by robertm

Resolution: wontfix
Status: newclosed

Hi Mathieu,

I have thought a bit about this patch over the past day, and have come to the decision that it it probably best not to open the floodgates of configuration options for every last little behavior in Jamu. I understand the desire to homogenize the data coming in from the grabber sources, but I am uncomfortable with adopting a configuration option for every little thing, especially when Jamu is meant as a stopgap convenience script whose extra functionality is being added to Myth over time. What's more, TMDB is in the midst of a total API rewrite and a lot of these Genre issues are going to be cleared up as a part of that.

I appreciate the willingness to improve Myth very much, and encourage you to continue your efforts to do so. I am just not comfortable with making Jamu more difficult to use than some people already find it.

Thanks.

Note: See TracTickets for help on using tickets.