Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7653 closed patch (fixed)

lircrcd needs CODEs to end with "\n"

Reported by: teague@… Owned by: Isaac Richards
Priority: minor Milestone: 0.23
Component: MythTV - General Version: 0.22
Severity: medium Keywords: lirc libmythui
Cc: Ticket locked: no


I want to use lircrcd to switch lirc modes when I spawn mplayer to watch videos. (lircrcd talks with all lirc clients to coordinate lirc modes across different clients.) At least as of lirc 0.8.5, lircrcd needs the CODE commands it receives over its socket to end with "\n", else it dies - but the version of lirc_client.c included in libmythui doesn't end its CODEs with "\n".

The attached patch is trivial, and adds "\n" to lirc_code2char in libmythui/lirc_client.c. It does not impact the behavior of lirc or mythtv when not using lircrcd (tested.) It is svn diffed against 22-fixes.

Attachments (1)

mythtv_lirc_code.diff (450 bytes) - added by teague@… 11 years ago.
Adds "\n" to end of CODE in libmythui/lirc_client.c

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by teague@…

Attachment: mythtv_lirc_code.diff added

Adds "\n" to end of CODE in libmythui/lirc_client.c

comment:1 Changed 11 years ago by stuartm

Component: MythTV - User Interface LibraryMythTV - General
Owner: changed from stuartm to Isaac Richards

comment:2 Changed 11 years ago by beirdo

Resolution: fixed
Status: newclosed

(In [23767]) Send \n after CODE transmissions to lircd. Fixes #7653

comment:3 Changed 11 years ago by beirdo

Milestone: unknown0.23
Note: See TracTickets for help on using tickets.