Opened 10 years ago

Closed 10 years ago

#7662 closed patch (fixed)

Patch to display help in mythfrontend if there is no configured X server

Reported by: doug@… Owned by: danielk
Priority: minor Milestone: 0.23
Component: MythTV - General Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This is a simple patch so that mythfrontend -h will display the help text even if there is no X Server to attach to.

Thanks!
Doug

Attachments (3)

help.patch (463 bytes) - added by doug@… 10 years ago.
help2.patch (3.8 KB) - added by doug@… 10 years ago.
patch version 2
help3.patch (4.4 KB) - added by doug@… 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by doug@…

Attachment: help.patch added

comment:1 Changed 10 years ago by doug@…

hmmm - this raises a new issue in that it shows the generic help and not the mythfrontend specific help. I think this patch needs some additional work.

Changed 10 years ago by doug@…

Attachment: help2.patch added

patch version 2

comment:2 Changed 10 years ago by doug@…

Patch #2 is slightly more complicated. It allows a calling program (e.g. mythfrontend) to send a callback to the command line parser. This callback then gets passed what the command liner parser would have printed as a QString. This enabled mythfrontend to print its specific parameters as well as a formatted string of the generic parameters in a way that looks normal.

Changed 10 years ago by doug@…

Attachment: help3.patch added

comment:3 Changed 10 years ago by doug@…

help3.patch has a slight change to the callback to take a MythCommandLineParser? instead of a QString. This allows the ShowUsage? functions in mythfrontend and mythwelcome to stay exactly the same. The MythCommandLineParser? now passes itself in the callback so that the calling function can do whatever it wants with the parser. This also adds mythwelcome to the patch which was the only other executable I found that has this issue.

comment:4 Changed 10 years ago by danielk

Milestone: unknown0.23
Owner: changed from Isaac Richards to danielk
Status: newaccepted

comment:5 Changed 10 years ago by danielk

Resolution: fixed
Status: acceptedclosed

(In [22912]) Fixes #7662. Print mythfrontend help even if display is absent.

Note: See TracTickets for help on using tickets.