Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#7674 closed defect (fixed)

MythWeb cover_images

Reported by: soless@… Owned by: Rob Smith
Priority: minor Milestone: 0.23
Component: Plugin - MythWeb Version: 0.22-fixes
Severity: medium Keywords:
Cc: Ticket locked: yes

Description

There is a small problem in 0.22 version of MythTV mythWeb plugin: the cover_image of the video file associated through mythfrontend is not shown via mythweb and cover_image added through mythweb plugin is not shown in myth-frontend...

Attachments (6)

diff.tar.gz (761 bytes) - added by soless@… 10 years ago.
small workaround
patches.tar.gz (2.3 KB) - added by soless@… 10 years ago.
fix-video-artwork.diff (2.0 KB) - added by Simon Kenyon <simon@…> 10 years ago.
small patch to classes/Video.php which changes assumption that coverart path is stored in the database to just the filename
Video.php.diff (1.1 KB) - added by soless@… 10 years ago.
Fixed version of patch, using a relative path to video_covers dir
coverart.diff (10.5 KB) - added by Simon Kenyon <simon@…> 10 years ago.
patch to mythweb to stream coverart
coverart.2.diff (10.5 KB) - added by Simon Kenyon <simon@…> 10 years ago.

Download all attachments as: .zip

Change History (14)

Changed 10 years ago by soless@…

Attachment: diff.tar.gz added

small workaround

comment:1 in reply to:  description Changed 10 years ago by anonymous

Replying to soless@…:

There is a small problem in 0.22 version of MythTV mythWeb plugin: the cover_image of the video file associated through mythfrontend is not shown via mythweb and cover_image added through mythweb plugin is not shown in myth-frontend...

problem still exists... here is little bit fixed patches + additional script for making thunbnails in video module...

Changed 10 years ago by soless@…

Attachment: patches.tar.gz added

comment:2 Changed 10 years ago by Simon Kenyon <simon@…>

please find attached my alternative patch to mythweb/classes/Video.php the only change is to get the path of the coverart directory from the database and not using a hard coded value

Changed 10 years ago by Simon Kenyon <simon@…>

Attachment: fix-video-artwork.diff added

small patch to classes/Video.php which changes assumption that coverart path is stored in the database to just the filename

Changed 10 years ago by soless@…

Attachment: Video.php.diff added

Fixed version of patch, using a relative path to video_covers dir

comment:3 Changed 10 years ago by Stuart Auchterlonie

Milestone: unknown0.23

comment:4 Changed 10 years ago by Simon Kenyon <simon@…>

Here is an alternative patch which gets the coverart storage groups from the database and then tries to find the coverart in those directories. the assumption (and i know it is bogus, but it is how i have set my system up) is that the files (if remote) are mounted in the same location as if they were local.

e.g. two machines sanfrancisco (master backend) and newyork (slave backend) coverart is in sanfrancisco:/myth/sanfrancisco/coverart and newyork:/myth/newyork/coverart

the url that is generated to retrieve the coverart is of the form pl/coverart/12345.jpg and there is a small perl module which streams this to the browser

this means that the data/video_covers symbolic link is not required

not proper storage group support, but a point on the way there

Changed 10 years ago by Simon Kenyon <simon@…>

Attachment: coverart.diff added

patch to mythweb to stream coverart

Changed 10 years ago by Simon Kenyon <simon@…>

Attachment: coverart.2.diff added

comment:5 Changed 10 years ago by Simon Kenyon <simon@…>

never make a tiny last minute change without testing it!

comment:6 Changed 10 years ago by Rob Smith

Resolution: fixed
Status: newclosed

(In [23679]) Fixes #7674, this allows the mythweb coverart to work correctly with storage groups again

comment:7 Changed 10 years ago by soless@…

and what about size of thumbnails in library??? 1 poster (~350-500 kb) * 1000+ on page = 300+ Mb RAM

i think it's not good :)

comment:8 Changed 10 years ago by Raymond Wagner

Ticket locked: set

Scaling or paging of cover images is unrelated to this ticket, and would be considered a feature request. Trac is not the proper place for those.

Note: See TracTickets for help on using tickets.