Opened 14 years ago

Closed 14 years ago

#771 closed defect (fixed)

Use of aspect when should be format in All detection method

Reported by: paulx@… Owned by: cpinkham
Priority: minor Milestone: 0.19
Component: mythtv Version: head
Severity: medium Keywords: commercial flagging
Cc: Ticket locked: no

Description

In ClassicCommDetector::BuildAllMethodsCommList? a loop searches for the most common format (NORMAL, LETTERBOX, PILLARBOX) but the current code uses aspect instead of format.

This is broken in 18.1 and head.

Attachments (1)

CommDetectFix.diff (506 bytes) - added by paulx@… 14 years ago.
Patch to fix

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by paulx@…

Attachment: CommDetectFix.diff added

Patch to fix

comment:1 Changed 14 years ago by cpinkham

Owner: changed from Chris Pinkham to cpinkham
Status: newassigned

comment:2 Changed 14 years ago by cpinkham

Resolution: fixed
Status: assignedclosed

(In [8198]) Bugfix in Commercial detection of letterbox/pillarbox video. The code was trying to find the prevalent type of frame in the recording but was checking the aspect flag for the frame not the format flag. Patch by Paul Andreassen.

Closes #771.

Note: See TracTickets for help on using tickets.