Opened 10 years ago

Closed 6 years ago

Last modified 6 years ago

#7730 closed Patch - Bug Fix (fixed)

Mythweb - allow direct downloading of .mkv, .avi, .mp4, .xvid, .okv files

Reported by: barry253@… Owned by: Karl Egly
Priority: trivial Milestone: 0.26.2
Component: Plugin - MythWeb Version: 0.22-fixes
Severity: medium Keywords: mythweb download mkv ogg avi mp4 xvid
Cc: Ticket locked: no

Description

Using 0.22-fixes, ver 22594

Trying to "Direct Download" any filetype in Recordings other than mpeg, mpg, or nuv results in "Unknown filetype" error.

This patch allows for downloads of multiple filetypes, useful when manually importing files into the database.

If the format of the patch is incorrect, I apologize in advance - this is my first time doing this.

Attachments (3)

stream_raw.pl.diff (1.3 KB) - added by barry253@… 10 years ago.
modified stream_raw.pl to allow for Direct Download of multiple filetypes
stream_raw.pl.2.diff (1.3 KB) - added by barry253@… 10 years ago.
now ADDING the patch to the file, not removing. whoops.
stream_raw.pl (1.1 KB) - added by dwgoldfarb@… 6 years ago.
Add mp4, avi, mov, wmv, 3gp, ogv, webm to the types that can be directly downloaded

Download all attachments as: .zip

Change History (13)

Changed 10 years ago by barry253@…

Attachment: stream_raw.pl.diff added

modified stream_raw.pl to allow for Direct Download of multiple filetypes

comment:1 Changed 10 years ago by robertm

Priority: minortrivial
Status: newinfoneeded_new
Type: defectenhancement

Barry, looks like you diffed this in reverse-- this is a patch for removing your enhancement. ;)

Try changing the order of the files in your diff -u command, or simply patch an svn copy and use "svn diff" to create the patch.

Changed 10 years ago by barry253@…

Attachment: stream_raw.pl.2.diff added

now ADDING the patch to the file, not removing. whoops.

comment:2 Changed 10 years ago by robertm

Status: infoneeded_newnew

comment:3 Changed 10 years ago by robertm

Status: newinfoneeded_new

Barry, did you test this? It is full of mismatched braces. I'm no PHP expert, but presumably you still need to close the brace you open.

comment:4 Changed 10 years ago by robertm

Resolution: wontfix
Status: infoneeded_newclosed

No update to the patch to address the mismatched braces. Please feel free to re-open when you have a tested, syntactically correct version.

Changed 6 years ago by dwgoldfarb@…

Attachment: stream_raw.pl added

Add mp4, avi, mov, wmv, 3gp, ogv, webm to the types that can be directly downloaded

comment:5 Changed 6 years ago by dwgoldfarb@…

I have re-opened the ticket and added an updated patch adding additional filetypes to allow them to be direct downloaded. I use a "userjob" to transcode recordings into MP4 format, and have tested the patch with that format.

comment:6 Changed 6 years ago by dwgoldfarb@…

Resolution: wontfix
Status: closednew

Attached patch for commit.

comment:7 Changed 6 years ago by Karl Dietz <dekarl@…>

Resolution: fixed
Status: newclosed

In c82601f426ba87ec86ffa6c4f076f7b325c9b902/mythweb:

Mythweb - allow direct downloading of .mkv, .avi, .mp4, .xvid, .okv files

Patch by Barry Rosenstock and David Goldfarb

Fixes #7730

comment:8 Changed 6 years ago by Karl Dietz <dekarl@…>

In a492e9343caff760e0081f785d540ca6a1fe39fa/mythweb:

Mythweb - allow direct downloading of .mkv, .avi, .mp4, .xvid, .okv files

Patch by Barry Rosenstock and David Goldfarb

Fixes #7730
(cherry picked from commit c82601f426ba87ec86ffa6c4f076f7b325c9b902)

comment:9 Changed 6 years ago by Karl Dietz <dekarl@…>

In af85819a2747f9fca781a1fe54d542ea6999f02d/mythweb:

Mythweb - allow direct downloading of .mkv, .avi, .mp4, .xvid, .okv files

Patch by Barry Rosenstock and David Goldfarb

Fixes #7730
(cherry picked from commit c82601f426ba87ec86ffa6c4f076f7b325c9b902)

comment:10 Changed 6 years ago by Karl Egly

Milestone: unknown0.26.2
Owner: changed from Rob Smith to Karl Egly
Type: enhancementPatch - Bug Fix
Note: See TracTickets for help on using tickets.