Opened 10 years ago

Closed 10 years ago

#7738 closed patch (fixed)

Accented characters in EIA-708 (ATSC) closed captions show up as boxes

Reported by: Clayton Smith <argilo@…> Owned by: danielk
Priority: minor Milestone: unknown
Component: MythTV - ATSC Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Accented characters in EIA-708 closed captions (on ATSC stations) do not show up correctly. They appear as boxes.

The underlying problem is sign extension which occurs when characters are converted from char to ushort in the CCtableG1 array. (For example, the character 0xE0 becomes 0xFFE0 instead of 0x00E0 when it is converted.)

Attached is a patch which corrects this problem by adding casts to uchar into the definition of CCtableG1.

Attachments (2)

fix-accented-characters.patch​ (3.0 KB) - added by Clayton Smith <argilo@…> 10 years ago.
Fix accented characters in EIA-708 closed captions
music-note-correction.patch​ (620 bytes) - added by Clayton Smith <argilo@…> 10 years ago.
Patch for music note

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Clayton Smith <argilo@…>

Attachment: fix-accented-characters.patch​ added

Fix accented characters in EIA-708 closed captions

Changed 10 years ago by Clayton Smith <argilo@…>

Attachment: music-note-correction.patch​ added

Patch for music note

comment:1 Changed 10 years ago by Clayton Smith <argilo@…>

The music note character also shows up as a square since its code point is incorrect. I've corrected it to 0x266A (EIGHTH NOTE) in a second patch (music-note-correction.patch) which I've attached.

comment:2 Changed 10 years ago by danielk

Resolution: → fixed
Status: new → closed

(In [22980]) Fixes #7738. Fix codepoint for music note and ads casting for other >= 0x80 characters so they are not sign extended on conversion from char to ushort.

Note: See TracTickets for help on using tickets.