Opened 10 years ago

Closed 10 years ago

#7777 closed patch (fixed)

patch to fix network control 'play program chanid time' command

Reported by: Randy Rossi <randy.rossi@…> Owned by: cpinkham
Priority: minor Milestone: 0.22
Component: MythTV - General Version: head
Severity: medium Keywords: network control play program
Cc: Ticket locked: no

Description

network control waited for playback box screen before trying to play requested program and then tried to change the selected item in the recordings list to the found program, then play using playSelected() method.

There were three problems with this.

1st was a race condition: just because the playbackbox screen is visible, that doesn't mean it's done populating the recordings list ui items. So the network control handler method was searching within an empty list.

2nd problem was that the comparison to the program info record found was failing when it tried to set the current selected item, even if the recordings list was populated since it points to a different program info structure anyway (qvariants were different so set selected item would fail)

3rd problem was that the user might have a group filter that doesn't even include the item being searched for so we would have to switch to all programs filter before searching.

Solution was to have the network control handler method in playbackbox.cpp just use the programinfo structure it found from the database query instead of trying to simulate a user selecting it from the list.

Patches for both 0.22 and trunk included.

Attachments (2)

play_program-0.22.patch (1.3 KB) - added by Randy Rossi <randy.rossi@…> 10 years ago.
patch for 0.22 branch to fix network control play program command
play_program-trunk.patch (1.3 KB) - added by Randy Rossi <randy.rossi@…> 10 years ago.
patch to trunk to fix network control play program command

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Randy Rossi <randy.rossi@…>

Attachment: play_program-0.22.patch added

patch for 0.22 branch to fix network control play program command

Changed 10 years ago by Randy Rossi <randy.rossi@…>

Attachment: play_program-trunk.patch added

patch to trunk to fix network control play program command

comment:1 Changed 10 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham
Status: newassigned

comment:2 Changed 10 years ago by cpinkham

Resolution: fixed
Status: assignedclosed

(In [23380]) Rework the NetworkControl? "play program" command handler a little bit to allow it to work even when the program is not in the current view on the Watch Recordings screen.

Fixes #7777 using a sligthly modified patch by Randy Rossi.

This patch is a work-around for the first item mentioned in the ticket, but that will also be addressed in a later commit regarding #7716.

Note: See TracTickets for help on using tickets.