Opened 10 years ago

Closed 9 years ago

#7783 closed patch (fixed)

Add encoder names to MythTV Backend Status page in Mythweb

Reported by: lifter89@… Owned by: beirdo
Priority: minor Milestone: unknown
Component: MythTV - General Version: unknown
Severity: low Keywords:
Cc: Ticket locked: no

Description

I noticed that the Tuner Status page in Mythfrontend shows the device names of each encoder, but the MythTV Backend Status page in Mythweb simply shows "Encoder 1, etc.". This patch provides the device label information for each encoder.

Attachments (4)

encoderstatus.patch (1.5 KB) - added by lifter89@… 10 years ago.
Patch to add encoder device label to the MythTV Backend Status page in Mythweb
httpstatus.patch (3.2 KB) - added by lifter89@… 10 years ago.
Result of requested "svn diff" against the latest revision
httpstatus.2.patch (1.3 KB) - added by lifter89@… 10 years ago.
Updated patch (fixed formatting and headers)
httpstatus.3.patch (2.7 KB) - added by beirdo 9 years ago.
updated to svn 25410

Download all attachments as: .zip

Change History (17)

Changed 10 years ago by lifter89@…

Attachment: encoderstatus.patch added

Patch to add encoder device label to the MythTV Backend Status page in Mythweb

comment:1 Changed 10 years ago by robertm

Component: MythTV - GeneralPlugin - MythWeb
Owner: changed from Isaac Richards to Rob Smith

comment:2 Changed 10 years ago by robertm

Component: Plugin - MythWebMythTV - General
Owner: changed from Rob Smith to Isaac Richards

Not Mythweb, backend status page.

comment:3 Changed 10 years ago by robertm

Status: newinfoneeded_new

Lifter89, Need a proper unified diff to use this (make the change to an svn checkout and then do "svn diff" from the root of the checkout). Also, not sure why you removed the header but it seems unrelated to your patch.

comment:4 in reply to:  3 Changed 10 years ago by anonymous

I have the output from svn diff. How to I submit it to you?

Replying to robertm:

Lifter89, Need a proper unified diff to use this (make the change to an svn checkout and then do "svn diff" from the root of the checkout). Also, not sure why you removed the header but it seems unrelated to your patch.

comment:5 Changed 10 years ago by robertm

Attach to the ticket as a file.

Changed 10 years ago by lifter89@…

Attachment: httpstatus.patch added

Result of requested "svn diff" against the latest revision

comment:6 Changed 10 years ago by robertm

lifter,

Thanks for the patch, but you are still removing headers for some reason. This my be legitimate if they are no longer used, but they shouldn't be in this patch unless they are required for it to function. Can you provide an update?

comment:7 Changed 10 years ago by robertm

Also, your patch includes a lot of whitespace and unrelated formatting changes-- we're looking for a patch that *only* includes your additions, with no other formatting or header cleanup.

comment:8 Changed 10 years ago by lifter89@…

I'm unclear what you mean by "I'm removing headers". All I did was make the code changes then "svn diff" as requested. Can you clarify what is wrong/missing? Perhaps I'm unknowingly doing that somehow.

comment:9 Changed 10 years ago by robertm

You are removing the #include "autoexpire.h" and #include "mainserver.h" lines, seemingly without reason. You also seem to be making changes to random whitespace and HTML formatting that seem unrelated to adding the encoder name to this page.

Changed 10 years ago by lifter89@…

Attachment: httpstatus.2.patch added

Updated patch (fixed formatting and headers)

comment:10 Changed 10 years ago by lifter89@…

I looked at it further and saw what you meant by the headers, so I fixed that up as well as the formatting. I just attached a new version of the patch. I apologize for any inconvenience. Thanks for you patience (this is my 1st myth patch).

comment:11 Changed 10 years ago by robertm

Status: infoneeded_newnew

lifter,

Much better, thanks.

comment:12 Changed 9 years ago by beirdo

Owner: changed from Isaac Richards to beirdo
Status: newassigned

Since this is going nowhere fast, I'll take a look at it tonight.

Changed 9 years ago by beirdo

Attachment: httpstatus.3.patch added

updated to svn 25410

comment:13 Changed 9 years ago by beirdo

Resolution: fixed
Status: assignedclosed

(In [25411]) Add the encoder device label to the MythTV Backend Status page in MythWeb.

Moved the query from the provided patch into CardUtil?, adjusted to match current code.

Closes #7783

Note: See TracTickets for help on using tickets.