Opened 10 years ago

Closed 10 years ago

#7859 closed defect (fixed)

MythTV trunk compilation fixes for win32

Reported by: Jonathan Martens <jonathan@…> Owned by: Nigel
Priority: minor Milestone: 0.23
Component: Ports - Windows Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Applied patch makes MythTV trunk compile on Windows.

Attachments (2)

r23071-mythtv-win-compilation.patch (2.2 KB) - added by Jonathan Martens <jonathan@…> 10 years ago.
Fixes mythtv compilation in windows (r23071)
r23095-mythtv-win-compilation.patch (1.3 KB) - added by Jonathan Martens <jonathan@…> 10 years ago.
Newer (less invasive) patch fixing win32 compilation using MinGW, which I hope does not brake VS2008 compilation as was noted in the development mailinglist.

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by Jonathan Martens <jonathan@…>

Fixes mythtv compilation in windows (r23071)

comment:1 Changed 10 years ago by Jeff Lu <jll544@…>

Re: the patch, it might be better to put the #include <time.h> in compat.h, as is done for Mac OS. The three files changed already pull in compat.h directly or indirectly.

comment:2 Changed 10 years ago by Stuart Auchterlonie

Milestone: unknown0.23

comment:3 Changed 10 years ago by anonymous

You should not remove the #define NOMINMAX from compat.h. True that mingw already defines it and generates a redefinition warning, but official win32 headers don't (e.g. compiling under VS2008). Better to leave it in - it's standard practice for dealing with windows min/max mess.

comment:4 Changed 10 years ago by Stuart Auchterlonie

Does nobody learn proper use of preprocessor directives anymore?

#ifndef NOMINMAX #define NOMINMAX #endif

comment:5 in reply to:  4 Changed 10 years ago by Jonathan Martens <jonathan@…>

Replying to stuarta:

Does nobody learn proper use of preprocessor directives anymore?

#ifndef NOMINMAX
#define NOMINMAX
#endif

Yes I do, but failed to do so in my patch. I was unaware that compilation on VS2008 was being achieved as well.

comment:6 Changed 10 years ago by Jonathan Martens <jonathan@…>

Changes made in this patch seem to be required since [23037] etc, which is applied in order to make MythTV compile in VS2008.

I posted on the dev list to see if we can find what is the proper way to fix so MythTV will compile using MinGW as well as VS2008.

Changed 10 years ago by Jonathan Martens <jonathan@…>

Newer (less invasive) patch fixing win32 compilation using MinGW, which I hope does not brake VS2008 compilation as was noted in the development mailinglist.

comment:7 Changed 10 years ago by dblain

Resolution: fixed
Status: newclosed

(In [23137]) Changes to fix MinGW compile problems. Fixes #7859

Note: See TracTickets for help on using tickets.