Opened 14 years ago
Closed 14 years ago
#7859 closed defect (fixed)
MythTV trunk compilation fixes for win32
Reported by: | Owned by: | Nigel | |
---|---|---|---|
Priority: | minor | Milestone: | 0.23 |
Component: | Ports - Windows | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Applied patch makes MythTV trunk compile on Windows.
Attachments (2)
Change History (9)
Changed 14 years ago by
Attachment: | r23071-mythtv-win-compilation.patch added |
---|
comment:1 Changed 14 years ago by
Re: the patch, it might be better to put the #include <time.h> in compat.h, as is done for Mac OS. The three files changed already pull in compat.h directly or indirectly.
comment:2 Changed 14 years ago by
Milestone: | unknown → 0.23 |
---|
comment:3 Changed 14 years ago by
You should not remove the #define NOMINMAX from compat.h. True that mingw already defines it and generates a redefinition warning, but official win32 headers don't (e.g. compiling under VS2008). Better to leave it in - it's standard practice for dealing with windows min/max mess.
comment:4 follow-up: 5 Changed 14 years ago by
Does nobody learn proper use of preprocessor directives anymore?
#ifndef NOMINMAX #define NOMINMAX #endif
comment:5 Changed 14 years ago by
Replying to stuarta:
Does nobody learn proper use of preprocessor directives anymore?
#ifndef NOMINMAX #define NOMINMAX #endif
Yes I do, but failed to do so in my patch. I was unaware that compilation on VS2008 was being achieved as well.
comment:6 Changed 14 years ago by
Changes made in this patch seem to be required since [23037] etc, which is applied in order to make MythTV compile in VS2008.
I posted on the dev list to see if we can find what is the proper way to fix so MythTV will compile using MinGW as well as VS2008.
Changed 14 years ago by
Attachment: | r23095-mythtv-win-compilation.patch added |
---|
Newer (less invasive) patch fixing win32 compilation using MinGW, which I hope does not brake VS2008 compilation as was noted in the development mailinglist.
Fixes mythtv compilation in windows (r23071)