Opened 10 years ago

Closed 10 years ago

#7888 closed patch (wontfix)

Using PNG coverfiles from the file system with MythVideo

Reported by: mythtv@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: MythTV - General Version: 0.22
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Attached is a patch that enhances the MythVideo? plugin with respect to locating coverfiles for videos. If no coverfile is defined in the DB, with this patch, MythVideo? will look in the same directory as the video for a file that is named the same as the video, but ends in ".png". If such a file is found, the file will be used as the coverfile for the video.

This is very useful when used with an external method for creating coverfiles that drops screen captures of the videos into PNG files.

Please fold this into the mainline.

Thank you,
Garrick James

P.S. I am not subscribed to mythtv-dev. If you need to contact me, please email me directly or update the ticket log.

Attachments (1)

mythvideo_png_coverfile.patch (741 bytes) - added by mythtv@… 10 years ago.

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by mythtv@…

comment:1 Changed 10 years ago by mythtv@…

I apologize. I meant to create this ticket for MythVideo? and not MythTV - General. It doesn't appear that I can change that now.

comment:2 Changed 10 years ago by robertm

Resolution: wontfix
Status: newclosed

This patch goes about what it tries to do the wrong way. MythVideo? already performs an image hunt when you add a video. The correct way to do this would be to add the filename to this hunt, and expand the hunt to check the videostartupdir *and* Video Storage Group as a last resort.

I will consider this patch if the above implementation is attached to the ticket. I'm going to close it wontfix at the moment, but if you write a patch that meets the above requirements, please attach it here and comment, and I will re-open and review.

Note: See TracTickets for help on using tickets.