Opened 14 years ago

Closed 12 years ago

#789 closed defect (fixed)

files with no pts for video can get timestamps wrong

Reported by: Mark Spieth Owned by: Isaac Richards
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords: libavformat
Cc: Ticket locked: no

Description

if there is an occasional audio pts but never any video pts the video pts's have no baseline as estimate timings updates its guessed value. this value isnt cleared when the real stream is played. while this doesnt fix the underlying problem, it does fix the symptom as the start of all recordings is adjusted to 0 anyway. This is a problem with libavformat. patch attached which is not in libavformat and will be compatible with any fix to libavformat if and when I have time. innocuous to streams with pts's for all streams. file I had is a mpegps. patch attached.

Attachments (2)

mythtv_novideopts.patch (430 bytes) - added by Mark Spieth 14 years ago.
mythtv_novideopts_laf.patch (2.1 KB) - added by Mark Spieth 14 years ago.

Download all attachments as: .zip

Change History (10)

Changed 14 years ago by Mark Spieth

Attachment: mythtv_novideopts.patch added

Changed 14 years ago by Mark Spieth

Attachment: mythtv_novideopts_laf.patch added

comment:1 Changed 14 years ago by Mark Spieth

2nd patch attached which is required in addition to the first patch. does not provide any extra functionality for myth but makes libavformat more robust if the 0 initial timestamp patch is not there. should be submitted to ffmpeg people. the first patch is very necessary though.

comment:2 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [8244]) Close #789 by applying patch.

comment:3 Changed 14 years ago by danielk

(In [8265]) References #789. Reverts [8244].

This is causing playback problems with some streams :(

comment:4 Changed 14 years ago by danielk

Resolution: fixed
Status: closedreopened

comment:5 Changed 14 years ago by danielk

(In [8267]) References #789.

Reapply, mythtv_novideopts.patch; it appears to be safe.

comment:6 Changed 14 years ago by danielk

Milestone: 0.190.20

comment:7 Changed 13 years ago by Isaac Richards

Milestone: 0.200.21

comment:8 Changed 12 years ago by stuartm

Resolution: fixed
Status: reopenedclosed

The second patch was applied upstream I'm told and the first was reapplied. So this can now be closed, re-open if there is a reason for it to still be open.

Note: See TracTickets for help on using tickets.