Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#7892 closed patch (fixed)

[PATCH] AVChapter support (includes MKV)

Reported by: tralph11@… Owned by: markk
Priority: minor Milestone: 0.23
Component: MythTV - Video Playback Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch provides AVChapter support for MythTV. Any ffmpeg container that has chapter capability is supported. At this time it appears only Matroska and Nut support chapters.

Here are some important aspects:

  • If chapters are detected during playback then the JUMPRWND and JUMPFFWD keys will navigate the chapters otherwise these keys will default back to 10 minute jumps. For consistency these are the same key bindings used for DVD chapter navigation.
  • When jumping to a previous chapter it will jump to the beginning of the current chapter unless you are within 1 second of the start. If you are within one second it will jump to the previous chapter. This might need to be increased to something more than 1 second.

Any comments/feedback should be posted on the mythtv-dev mailing list.

Attachments (4)

t7892_avchapter_support_v1.diff (11.1 KB) - added by tralph11@… 10 years ago.
AVChapter support
t7892_avchapter_support_v2.diff (10.9 KB) - added by taylor.ralph@… 10 years ago.
clean up code and change previous chapter delay from 1.0 to 2.0 seconds
t7892_avchapter_support_v3.diff (10.9 KB) - added by taylor.ralph@… 10 years ago.
final update (trunk 23210)
t7892_clear_subtitles.diff (461 bytes) - added by taylor.ralph@… 10 years ago.
clear subtitles when changing chapters

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by tralph11@…

AVChapter support

Changed 10 years ago by taylor.ralph@…

clean up code and change previous chapter delay from 1.0 to 2.0 seconds

Changed 10 years ago by taylor.ralph@…

final update (trunk 23210)

comment:1 Changed 10 years ago by markk

Owner: changed from Janne Grunau to markk
Status: newaccepted

comment:2 Changed 10 years ago by markk

Resolution: fixed
Status: acceptedclosed

(In [23226]) Add AVChapter support with patch from Taylor Ralph. Closes #7892.

The only significant change I've made to the original patch is to extend chapter changing to the CHANNELUP and CHANNELDOWN actions. This ensures that playback behaviour is entirely consistent between DVD playback and, for example, a matroska version of that same DVD content.

Changed 10 years ago by taylor.ralph@…

Attachment: t7892_clear_subtitles.diff added

clear subtitles when changing chapters

comment:3 Changed 10 years ago by markk

(In [23299]) Clear subtitles when changing chapter. Patch from Taylor Ralph.

Refs #7892.

Note: See TracTickets for help on using tickets.